[Autofill] Use const string16& parameter type, removing the need for explicit move

[Autofill] Use const string16& parameter type, removing the need for explicit move

As brought up in https://codereview.chromium.org/1622073002/

BUG=None

Committed: https://crrev.com/f1edf87bbb67bc31fa9d280736753132fd81f103
Cr-Commit-Position: refs/heads/master@{#371518}

[Mathieu, 2016-01-26 14:15:08]

Description was changed from

==========
[Autofill] Use const string16& parameter type, removing the need for explicit
move

As brought up in https://codereview.chromium.org/1622073002/

BUG=None
==========

to

==========
[Autofill] Use const string16& parameter type, removing the need for explicit
move

As brought up in https://codereview.chromium.org/1622073002/

BUG=None
==========

[Mathieu, 2016-01-26 14:15:08]

mathp@chromium.org changed reviewers:
+ vabr@chromium.org

[Mathieu, 2016-01-26 14:15:21]

Thanks for following up Vaclav!

[vabr (Chromium), 2016-01-26 14:41:00]

LGTM!

Out of the two main reasons given in the recent chromium-dev thread for why
const ref is preferred, the one about avoiding copy-and-paste mistakes makes me
sad (although I actually think it is valid), but the one with the pointer to
Sutter's talk is very interesting:

The fallacy in my reasoning was that while the number of string copies is never
higher when one uses value+move, the time needed for the copy might be higher in
the value+move scenario, in cases when the assigned-to string is already
existing and has enough space allocated.

Sorry for back-and-forth, this is an educational time for me. :)

Cheers,
Vaclav

[Mathieu, 2016-01-26 14:45:53]

On 2016/01/26 14:41:00, vabr (Chromium) wrote:
> LGTM!
> 
> Out of the two main reasons given in the recent chromium-dev thread for why
> const ref is preferred, the one about avoiding copy-and-paste mistakes makes
me
> sad (although I actually think it is valid), but the one with the pointer to
> Sutter's talk is very interesting:
> 
> The fallacy in my reasoning was that while the number of string copies is
never
> higher when one uses value+move, the time needed for the copy might be higher
in
> the value+move scenario, in cases when the assigned-to string is already
> existing and has enough space allocated.
> 
> Sorry for back-and-forth, this is an educational time for me. :)
> 
> Cheers,
> Vaclav

Yep, that was interesting. Thanks.

[Mathieu, 2016-01-26 14:45:55]

The CQ bit was checked by mathp@chromium.org

[commit-bot: I haz the power, 2016-01-26 14:46:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1624373004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1624373004/1

[commit-bot: I haz the power, 2016-01-26 15:42:08]

Description was changed from

==========
[Autofill] Use const string16& parameter type, removing the need for explicit
move

As brought up in https://codereview.chromium.org/1622073002/

BUG=None
==========

to

==========
[Autofill] Use const string16& parameter type, removing the need for explicit
move

As brought up in https://codereview.chromium.org/1622073002/

BUG=None
==========

[commit-bot: I haz the power, 2016-01-26 15:42:09]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-01-26 15:44:37]

Description was changed from

==========
[Autofill] Use const string16& parameter type, removing the need for explicit
move

As brought up in https://codereview.chromium.org/1622073002/

BUG=None
==========

to

==========
[Autofill] Use const string16& parameter type, removing the need for explicit
move

As brought up in https://codereview.chromium.org/1622073002/

BUG=None

Committed: https://crrev.com/f1edf87bbb67bc31fa9d280736753132fd81f103
Cr-Commit-Position: refs/heads/master@{#371518}
==========

[commit-bot: I haz the power, 2016-01-26 15:44:38]

Patchset 1 (id:??) landed as
https://crrev.com/f1edf87bbb67bc31fa9d280736753132fd81f103
Cr-Commit-Position: refs/heads/master@{#371518}