Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Unified Diff: components/autofill/core/browser/autofill_field.h

Issue 1624373004: [Autofill] Use const string16& parameter type, removing the need for explicit move (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/autofill/core/browser/autofill_field.h
diff --git a/components/autofill/core/browser/autofill_field.h b/components/autofill/core/browser/autofill_field.h
index 6c9d5231eb044735c0be8b3720a9e6ca1504cd7d..8295440e822399546488b52305ac3e893819de29 100644
--- a/components/autofill/core/browser/autofill_field.h
+++ b/components/autofill/core/browser/autofill_field.h
@@ -53,8 +53,8 @@ class AutofillField : public FormFieldData {
void set_previously_autofilled(bool previously_autofilled) {
previously_autofilled_ = previously_autofilled;
}
- void set_parseable_name(base::string16 parseable_name) {
- parseable_name_ = std::move(parseable_name);
+ void set_parseable_name(const base::string16& parseable_name) {
+ parseable_name_ = parseable_name;
}
// This function automatically chooses between server and heuristic autofill
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698