Send enums as strings between Chromoting Native Messaging host and web-app.

remoting/host/setup/native_messaging_host_unittest.cc

Index: remoting/host/setup/native_messaging_host_unittest.cc
diff --git a/remoting/host/setup/native_messaging_host_unittest.cc b/remoting/host/setup/native_messaging_host_unittest.cc
index b6fc4abf156bf62a412043e33b8fa63995dbc1bb..225c8ad8378330a56b9e019825d32f8a1e47fa8c 100644
--- a/remoting/host/setup/native_messaging_host_unittest.cc
+++ b/remoting/host/setup/native_messaging_host_unittest.cc
@@ -85,9 +85,8 @@ void VerifyStopDaemonResponse(const base::DictionaryValue* response) {
   std::string value;
   EXPECT_TRUE(response->GetString("type", &value));
   EXPECT_EQ("stopDaemonResponse", value);
-  int result;
-  EXPECT_TRUE(response->GetInteger("result", &result));
-  EXPECT_EQ(0, result);
+  EXPECT_TRUE(response->GetString("result", &value));
+  EXPECT_EQ(remoting::NativeMessagingHost::kResultOk, value);

[Sergey Ulanov, 2013/05/31 23:01:43]

I'd rather not bother about sharing constants with the unittests. Just use "OK"
here. You are already duplicating many other strings anyway.

[Lambros, 2013/06/03 21:28:44]

Done.

 }
 
 void VerifyGetDaemonStateResponse(const base::DictionaryValue* response) {
@@ -95,9 +94,8 @@ void VerifyGetDaemonStateResponse(const base::DictionaryValue* response) {
   std::string value;
   EXPECT_TRUE(response->GetString("type", &value));
   EXPECT_EQ("getDaemonStateResponse", value);
-  int result;
-  EXPECT_TRUE(response->GetInteger("state", &result));
-  EXPECT_EQ(4, result);
+  EXPECT_TRUE(response->GetString("state", &value));
+  EXPECT_EQ(remoting::NativeMessagingHost::kStateStarted, value);
 }
 
 void VerifyUpdateDaemonConfigResponse(const base::DictionaryValue* response) {
@@ -105,9 +103,8 @@ void VerifyUpdateDaemonConfigResponse(const base::DictionaryValue* response) {
   std::string value;
   EXPECT_TRUE(response->GetString("type", &value));
   EXPECT_EQ("updateDaemonConfigResponse", value);
-  int result;
-  EXPECT_TRUE(response->GetInteger("result", &result));
-  EXPECT_EQ(0, result);
+  EXPECT_TRUE(response->GetString("result", &value));
+  EXPECT_EQ(remoting::NativeMessagingHost::kResultOk, value);
 }
 
 void VerifyStartDaemonResponse(const base::DictionaryValue* response) {
@@ -115,9 +112,8 @@ void VerifyStartDaemonResponse(const base::DictionaryValue* response) {
   std::string value;
   EXPECT_TRUE(response->GetString("type", &value));
   EXPECT_EQ("startDaemonResponse", value);
-  int result;
-  EXPECT_TRUE(response->GetInteger("result", &result));
-  EXPECT_EQ(0, result);
+  EXPECT_TRUE(response->GetString("result", &value));
+  EXPECT_EQ(remoting::NativeMessagingHost::kResultOk, value);
 }
 
 }  // namespace