Send enums as strings between Chromoting Native Messaging host and web-app.

remoting/host/setup/native_messaging_host_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "remoting/host/setup/native_messaging_host.h"
 
 #include "base/compiler_specific.h"
 #include "base/json/json_reader.h"
 #include "base/json/json_writer.h"
 #include "base/message_loop.h"
@@ skipping 67 matching lines @@
   EXPECT_TRUE(supported);
   EXPECT_TRUE(allowed);
   EXPECT_TRUE(set_by_policy);
 }
 
 void VerifyStopDaemonResponse(const base::DictionaryValue* response) {
   ASSERT_TRUE(response);
   std::string value;
   EXPECT_TRUE(response->GetString("type", &value));
   EXPECT_EQ("stopDaemonResponse", value);
-  int result;
-  EXPECT_TRUE(response->GetInteger("result", &result));
-  EXPECT_EQ(0, result);
+  EXPECT_TRUE(response->GetString("result", &value));
+  EXPECT_EQ(remoting::NativeMessagingHost::kResultOk, value);

[Sergey Ulanov, 2013/05/31 23:01:43]

I'd rather not bother about sharing constants with the unittests. Just use "OK"
here. You are already duplicating many other strings anyway.

[Lambros, 2013/06/03 21:28:44]

Done.

 }
 
 void VerifyGetDaemonStateResponse(const base::DictionaryValue* response) {
   ASSERT_TRUE(response);
   std::string value;
   EXPECT_TRUE(response->GetString("type", &value));
   EXPECT_EQ("getDaemonStateResponse", value);
-  int result;
-  EXPECT_TRUE(response->GetInteger("state", &result));
-  EXPECT_EQ(4, result);
+  EXPECT_TRUE(response->GetString("state", &value));
+  EXPECT_EQ(remoting::NativeMessagingHost::kStateStarted, value);
 }
 
 void VerifyUpdateDaemonConfigResponse(const base::DictionaryValue* response) {
   ASSERT_TRUE(response);
   std::string value;
   EXPECT_TRUE(response->GetString("type", &value));
   EXPECT_EQ("updateDaemonConfigResponse", value);
-  int result;
-  EXPECT_TRUE(response->GetInteger("result", &result));
-  EXPECT_EQ(0, result);
+  EXPECT_TRUE(response->GetString("result", &value));
+  EXPECT_EQ(remoting::NativeMessagingHost::kResultOk, value);
 }
 
 void VerifyStartDaemonResponse(const base::DictionaryValue* response) {
   ASSERT_TRUE(response);
   std::string value;
   EXPECT_TRUE(response->GetString("type", &value));
   EXPECT_EQ("startDaemonResponse", value);
-  int result;
-  EXPECT_TRUE(response->GetInteger("result", &result));
-  EXPECT_EQ(0, result);
+  EXPECT_TRUE(response->GetString("result", &value));
+  EXPECT_EQ(remoting::NativeMessagingHost::kResultOk, value);
 }
 
 }  // namespace
 
 namespace remoting {
 
 class MockDaemonController : public DaemonController {
  public:
   MockDaemonController();
   virtual ~MockDaemonController();
@@ skipping 377 matching lines @@
 
 // Verify rejection if startDaemon request has no "consent" parameter.
 TEST_F(NativeMessagingHostTest, StartDaemonNoConsent) {
   base::DictionaryValue message;
   message.SetString("type", "startDaemon");
   message.Set("config", base::DictionaryValue().DeepCopy());
   TestBadRequest(message);
 }
 
 }  // namespace remoting