Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Unified Diff: content/renderer/media/rtc_peer_connection_handler.cc

Issue 16232004: Adds DataChannelInit param to createDataChannel. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/rtc_peer_connection_handler.cc
diff --git a/content/renderer/media/rtc_peer_connection_handler.cc b/content/renderer/media/rtc_peer_connection_handler.cc
index ab2ebcc1affb64e43e52964950a6113164edf363..b103fab26fee2535a0ab180320f3a04b1b5fe604 100644
--- a/content/renderer/media/rtc_peer_connection_handler.cc
+++ b/content/renderer/media/rtc_peer_connection_handler.cc
@@ -578,6 +578,11 @@ void RTCPeerConnectionHandler::GetStats(
}
WebKit::WebRTCDataChannelHandler* RTCPeerConnectionHandler::createDataChannel(
Ami GONE FROM CHROMIUM 2013/06/03 18:27:31 nit: keep order in .h same as in .cc
jiayl 2013/06/03 18:52:58 Done.
+ const WebKit::WebString& label, const WebKit::WebRTCDataChannelInit& init) {
+ return createDataChannel(label, false);
Ami GONE FROM CHROMIUM 2013/06/03 18:27:31 s/false/ordered && maxRetransmitTime == 0 && maxRe
jiayl 2013/06/03 18:52:58 Libjingle rejects to create reliable RTP data chan
+}
+
+WebKit::WebRTCDataChannelHandler* RTCPeerConnectionHandler::createDataChannel(
const WebKit::WebString& label, bool reliable) {
DVLOG(1) << "createDataChannel label " << UTF16ToUTF8(label);

Powered by Google App Engine
This is Rietveld 408576698