Adds DataChannelInit param to createDataChannel.

content/renderer/media/rtc_peer_connection_handler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/media/rtc_peer_connection_handler.h"
 
 #include <string>
 #include <utility>
 #include <vector>
 
@@ skipping 559 matching lines @@
     webrtc::MediaStreamTrackInterface* track) {
   if (!native_peer_connection_->GetStats(observer, track)) {
     DVLOG(1) << "GetStats failed.";
     // TODO(hta): Consider how to get an error back.
     std::vector<webrtc::StatsReport> no_reports;
     observer->OnComplete(no_reports);
     return;
   }
 }
 
 WebKit::WebRTCDataChannelHandler* RTCPeerConnectionHandler::createDataChannel(

[Ami GONE FROM CHROMIUM, 2013/06/03 18:27:31]

nit: keep order in .h same as in .cc

[jiayl, 2013/06/03 18:52:58]

Done.

+    const WebKit::WebString& label, const WebKit::WebRTCDataChannelInit& init) {
+  return createDataChannel(label, false);

[Ami GONE FROM CHROMIUM, 2013/06/03 18:27:31]

s/false/ordered && maxRetransmitTime == 0 && maxRetransmits == 0/ ?

(per http://dev.w3.org/2011/webrtc/editor/webrtc.html#rtcdatachannel: 
A RTCDataChannel can be configured to operate in different reliability modes. A
reliable channel ensures that the data is delivered at the other peer through
retransmissions. An unreliable channel is configured to either limit the number
of retransmissions (maxRetransmits) or set a time during which retransmissions
are allowed (maxRetransmitTime). These properties can not be used simultaneously
and an attempt to do so will result in an error. Not setting any of these
properties results in a reliable channel.
)

[jiayl, 2013/06/03 18:52:58]

Libjingle rejects to create reliable RTP data channels and this will break
existing demos. I added a TODO to update this to the correct logic once
Libjingle can handle it.

On 2013/06/03 18:27:31, Ami Fischman wrote:

+}
+
+WebKit::WebRTCDataChannelHandler* RTCPeerConnectionHandler::createDataChannel(
     const WebKit::WebString& label, bool reliable) {
   DVLOG(1) << "createDataChannel label " << UTF16ToUTF8(label);
 
   webrtc::DataChannelInit config;
   config.reliable = reliable;
 
   talk_base::scoped_refptr<webrtc::DataChannelInterface> webrtc_channel(
       native_peer_connection_->CreateDataChannel(UTF16ToUTF8(label), &config));
   if (!webrtc_channel) {
     DLOG(ERROR) << "Could not create native data channel.";
@@ skipping 169 matching lines @@
   webrtc::SessionDescriptionInterface* native_desc =
       dependency_factory_->CreateSessionDescription(type, sdp, error);
 
   LOG_IF(ERROR, !native_desc) << "Failed to create native session description."
                               << " Type: " << type << " SDP: " << sdp;
 
   return native_desc;
 }
 
 }  // namespace content