Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1622983002: Revert[2] of expand unitests for color4f (Closed)

Created:
4 years, 11 months ago by reed2
Modified:
4 years, 11 months ago
Reviewers:
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert[2] of expand unitests for color4f This reverts commit 5f34e8ed82e6cbf29401bda5d423a50a2ab6db74. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1622983002 TBR= Committed: https://skia.googlesource.com/skia/+/7f225cf32e63e565b5ba584241672f58b48a9acb

Patch Set 1 #

Patch Set 2 : call the generic destructor, so we go throught the virtual chain #

Unified diffs Side-by-side diffs Delta from patch set Stats (+157 lines, -10 lines) Patch
M include/core/SkColor.h View 1 chunk +2 lines, -0 lines 0 comments Download
M include/core/SkColorFilter.h View 1 chunk +4 lines, -0 lines 0 comments Download
M include/core/SkShader.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/core/SkColor.cpp View 2 chunks +10 lines, -3 lines 0 comments Download
M tests/SkColor4fTest.cpp View 1 3 chunks +137 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1622983002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1622983002/20001
4 years, 11 months ago (2016-01-24 03:25:57 UTC) #4
commit-bot: I haz the power
4 years, 11 months ago (2016-01-24 03:38:00 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/7f225cf32e63e565b5ba584241672f58b48a9acb

Powered by Google App Engine
This is Rietveld 408576698