Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(476)

Issue 1622923002: Revert of expand unitests for color4f (Closed)

Created:
4 years, 11 months ago by reed2
Modified:
4 years, 11 months ago
Reviewers:
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of expand unitests for color4f (patchset #1 id:1 of https://codereview.chromium.org/1622893002/ ) Reason for revert: leaking shadercontext in test Original issue's description: > expand unitests for color4f > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1622893002 > > TBR= > > Committed: https://skia.googlesource.com/skia/+/fac684502b6047ffc7dc2e59bd7e5a7cbfa5bf78 TBR= # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/5f34e8ed82e6cbf29401bda5d423a50a2ab6db74

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -157 lines) Patch
M include/core/SkColor.h View 1 chunk +0 lines, -2 lines 0 comments Download
M include/core/SkColorFilter.h View 1 chunk +0 lines, -4 lines 0 comments Download
M include/core/SkShader.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/core/SkColor.cpp View 2 chunks +3 lines, -10 lines 0 comments Download
M tests/SkColor4fTest.cpp View 3 chunks +7 lines, -137 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
reed2
Created Revert of expand unitests for color4f
4 years, 11 months ago (2016-01-23 22:18:47 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1622923002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1622923002/1
4 years, 11 months ago (2016-01-23 22:19:01 UTC) #2
commit-bot: I haz the power
4 years, 11 months ago (2016-01-23 22:19:10 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/5f34e8ed82e6cbf29401bda5d423a50a2ab6db74

Powered by Google App Engine
This is Rietveld 408576698