Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 1622893002: expand unitests for color4f (Closed)

Created:
4 years, 11 months ago by reed2
Modified:
4 years, 11 months ago
Reviewers:
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+157 lines, -10 lines) Patch
M include/core/SkColor.h View 1 chunk +2 lines, -0 lines 0 comments Download
M include/core/SkColorFilter.h View 1 chunk +4 lines, -0 lines 0 comments Download
M include/core/SkShader.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/core/SkColor.cpp View 2 chunks +10 lines, -3 lines 0 comments Download
M tests/SkColor4fTest.cpp View 3 chunks +137 lines, -7 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1622893002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1622893002/1
4 years, 11 months ago (2016-01-23 18:04:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1622893002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1622893002/1
4 years, 11 months ago (2016-01-23 18:07:25 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/fac684502b6047ffc7dc2e59bd7e5a7cbfa5bf78
4 years, 11 months ago (2016-01-23 18:15:42 UTC) #9
reed2
4 years, 11 months ago (2016-01-23 22:18:47 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1622923002/ by reed@chromium.org.

The reason for reverting is: leaking shadercontext in test.

Powered by Google App Engine
This is Rietveld 408576698