Chromium Code Reviews Chromium Code Reviews
Issue
162283002:
Move towards event-driven JS on about:sync (Closed)
DescriptionMove towards event-driven JS on about:sync
Removes two callback-based about:sync functions and replaces them with
alternatives that are more event-based.
Replaces getAboutInfo and the onServiceStatusChanged event with
requestUpdatedAboutInfo and an onAboutInfoUpdated event. Unlike its
predecessor, the requestUpdatedAboutInfo function does not take a
callback. Instead, it requests that the message handler issue an
onAboutInfoUpdated event. It is assumed that the caller of this
function is already subscribed to receive a callback for this event.
The onAboutInfoUpdated event differs from its predecessor in that
it provides a 'details' member that contains the updated aboutInfo.
This CL also makes the SyncInternalsMessageHandler observe
ProfileSyncService events directly, rather than having these events
routed through the JsEventHandler.
Replaces getListOfTypes with requestListOfTypes. The new function
does not take a callback. The response will arrive in the form of
an onReceivedListOfTypes event.
BUG=334431, 328606
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251851
Patch Set 1 #Patch Set 2 : Rebase + fix some issues #Patch Set 3 : Rebase + fix some issues (reupload) #
Total comments: 13
Patch Set 4 : Review fixes and rebase #
Total comments: 1
Patch Set 5 : Small fix and reupload #Patch Set 6 : Another reupload #
Messages
Total messages: 11 (0 generated)
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
