Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3717)

Unified Diff: chrome/browser/resources/sync_internals/data.js

Issue 162283002: Move towards event-driven JS on about:sync (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Another reupload Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/sync_internals/chrome_sync.js ('k') | chrome/browser/sync/profile_sync_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/sync_internals/data.js
diff --git a/chrome/browser/resources/sync_internals/data.js b/chrome/browser/resources/sync_internals/data.js
index 0f5c088632602f158fc930d08f2a1ec3dfd8ac55..c0ef90e6eb77f5d587c001325a9d622e9f3a587d 100644
--- a/chrome/browser/resources/sync_internals/data.js
+++ b/chrome/browser/resources/sync_internals/data.js
@@ -164,11 +164,20 @@ function createTypesCheckboxes(types) {
});
}
+function onReceivedListOfTypes(e) {
+ var types = e.details.types;
+ types.sort();
+ createTypesCheckboxes(types);
+ chrome.sync.events.removeEventListener(
+ 'onReceivedListOfTypes',
+ onReceivedListOfTypes);
+}
+
document.addEventListener('DOMContentLoaded', function() {
- chrome.sync.getListOfTypes(function(types) {
- types.sort();
- createTypesCheckboxes(types);
- });
+ chrome.sync.events.addEventListener(
+ 'onReceivedListOfTypes',
+ onReceivedListOfTypes);
+ chrome.sync.requestListOfTypes();
});
var dumpToFileLink = $('dump-to-file');
« no previous file with comments | « chrome/browser/resources/sync_internals/chrome_sync.js ('k') | chrome/browser/sync/profile_sync_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698