appengine/findit/waterfall/try_job_pipeline.py - Issue 1622813003: [Findit] Adding support for extracting revisions from dict instead of list

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/findit/waterfall/try_job_pipeline.py

Issue 1622813003: [Findit] Adding support for extracting revisions from dict instead of list (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master

Patch Set: Addressing code review comments Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: appengine/findit/waterfall/try_job_pipeline.py

diff --git a/appengine/findit/waterfall/try_job_pipeline.py b/appengine/findit/waterfall/try_job_pipeline.py

index c4de162c89ef72e700f4ae70f72e54c4430690b3..7413573f44c338e2deea3272d756889bbe88c134 100644

--- a/appengine/findit/waterfall/try_job_pipeline.py

+++ b/appengine/findit/waterfall/try_job_pipeline.py

@@ -51,7 +51,7 @@ class TryJobPipeline(BasePipeline):

try_job_id = yield ScheduleTryJobPipeline(

master_name, builder_name, build_number, good_revision, bad_revision,

compile_targets)

- compile_result = yield MonitorTryJobPipeline(

+ try_job_result = yield MonitorTryJobPipeline(

master_name, builder_name, build_number, try_job_id)

yield IdentifyTryJobCulpritPipeline(

- master_name, builder_name, build_number, try_job_id, compile_result)

+ master_name, builder_name, build_number, try_job_id, try_job_result)

« no previous file with comments | « appengine/findit/waterfall/test/try_job_pipeline_test.py ('k') | no next file » | no next file with comments »