Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Side by Side Diff: appengine/findit/waterfall/try_job_pipeline.py

Issue 1622813003: [Findit] Adding support for extracting revisions from dict instead of list (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: Addressing code review comments Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « appengine/findit/waterfall/test/try_job_pipeline_test.py ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 from pipeline_wrapper import BasePipeline 5 from pipeline_wrapper import BasePipeline
6 from model import wf_analysis_status 6 from model import wf_analysis_status
7 from model.wf_try_job import WfTryJob 7 from model.wf_try_job import WfTryJob
8 from waterfall.identify_try_job_culprit_pipeline import ( 8 from waterfall.identify_try_job_culprit_pipeline import (
9 IdentifyTryJobCulpritPipeline) 9 IdentifyTryJobCulpritPipeline)
10 from waterfall.monitor_try_job_pipeline import MonitorTryJobPipeline 10 from waterfall.monitor_try_job_pipeline import MonitorTryJobPipeline
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
44 """Finalizes this Pipeline after execution.""" 44 """Finalizes this Pipeline after execution."""
45 self._LogUnexpectedAbort(self.was_aborted) 45 self._LogUnexpectedAbort(self.was_aborted)
46 46
47 # Arguments number differs from overridden method - pylint: disable=W0221 47 # Arguments number differs from overridden method - pylint: disable=W0221
48 def run( 48 def run(
49 self, master_name, builder_name, build_number, 49 self, master_name, builder_name, build_number,
50 good_revision, bad_revision, compile_targets): 50 good_revision, bad_revision, compile_targets):
51 try_job_id = yield ScheduleTryJobPipeline( 51 try_job_id = yield ScheduleTryJobPipeline(
52 master_name, builder_name, build_number, good_revision, bad_revision, 52 master_name, builder_name, build_number, good_revision, bad_revision,
53 compile_targets) 53 compile_targets)
54 compile_result = yield MonitorTryJobPipeline( 54 try_job_result = yield MonitorTryJobPipeline(
55 master_name, builder_name, build_number, try_job_id) 55 master_name, builder_name, build_number, try_job_id)
56 yield IdentifyTryJobCulpritPipeline( 56 yield IdentifyTryJobCulpritPipeline(
57 master_name, builder_name, build_number, try_job_id, compile_result) 57 master_name, builder_name, build_number, try_job_id, try_job_result)
OLDNEW
« no previous file with comments | « appengine/findit/waterfall/test/try_job_pipeline_test.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698