Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Unified Diff: appengine/findit/common/test/buildbucket_client_test.py

Issue 1622813003: [Findit] Adding support for extracting revisions from dict instead of list (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: Addressing code review comments Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/common/test/buildbucket_client_test.py
diff --git a/appengine/findit/common/test/buildbucket_client_test.py b/appengine/findit/common/test/buildbucket_client_test.py
index 8e3676502c630fe1e43a9f957ef221401851a65d..4093950cddbf55f0c954e36961f7ff527b4c297c 100644
--- a/appengine/findit/common/test/buildbucket_client_test.py
+++ b/appengine/findit/common/test/buildbucket_client_test.py
@@ -84,11 +84,11 @@ class BuildBucketClientTest(testing.AppengineTestCase):
def testTriggerTryJobsSuccess(self):
response = {
- 'build': {
- 'id': '1',
- 'url': 'url',
- 'status': 'SCHEDULED',
- }
+ 'build': {
+ 'id': '1',
+ 'url': 'url',
+ 'status': 'SCHEDULED',
+ }
}
try_job = buildbucket_client.TryJob('m', 'b', 'r', {'a': 'b'}, [])
self._MockUrlFetch(
@@ -104,10 +104,10 @@ class BuildBucketClientTest(testing.AppengineTestCase):
def testTriggerTryJobsFailure(self):
response = {
- 'error': {
- 'reason': 'error',
- 'message': 'message',
- }
+ 'error': {
+ 'reason': 'error',
+ 'message': 'message',
+ }
}
try_job = buildbucket_client.TryJob('m', 'b', 'r', {}, [])
self._MockUrlFetch(
@@ -156,11 +156,11 @@ class BuildBucketClientTest(testing.AppengineTestCase):
self.assertEqual('url', build.url)
self.assertEqual('STARTED', build.status)
- expected_result = [
+ expected_report = [
['rev1', 'passed'],
['rev2', 'failed']
]
- self.assertEqual(expected_result, build.result)
+ self.assertEqual(expected_report, build.report)
def testGetTryJobsFailure(self):
response = {
« no previous file with comments | « appengine/findit/common/buildbucket_client.py ('k') | appengine/findit/waterfall/identify_try_job_culprit_pipeline.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698