[Findit] Adding support for extracting revisions from dict instead of list

appengine/findit/common/test/buildbucket_client_test.py

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import json
 
 from testing_utils import testing
 
 from common import buildbucket_client
 
@@ skipping 66 matching lines @@
       url = base_url + '/' + build_id
       self.mocked_urlfetch.register_handler(
           url, content, status_code=status_code, headers=headers)
     else:
       self.mocked_urlfetch.register_handler(
           base_url, content, status_code=status_code,
           headers=headers, data=try_job_request)
 
   def testTriggerTryJobsSuccess(self):
     response = {
-      'build': {
-          'id': '1',
-          'url': 'url',
-          'status': 'SCHEDULED',
-      }
+        'build': {
+            'id': '1',
+            'url': 'url',
+            'status': 'SCHEDULED',
+        }
     }
     try_job = buildbucket_client.TryJob('m', 'b', 'r', {'a': 'b'}, [])
     self._MockUrlFetch(
         None, json.dumps(try_job.ToBuildbucketRequest()), json.dumps(response))
     results = buildbucket_client.TriggerTryJobs([try_job])
     self.assertEqual(1, len(results))
     error, build = results[0]
     self.assertIsNone(error)
     self.assertIsNotNone(build)
     self.assertEqual('1', build.id)
     self.assertEqual('url', build.url)
     self.assertEqual('SCHEDULED', build.status)
 
   def testTriggerTryJobsFailure(self):
     response = {
-      'error': {
-          'reason': 'error',
-          'message': 'message',
-      }
+        'error': {
+            'reason': 'error',
+            'message': 'message',
+        }
     }
     try_job = buildbucket_client.TryJob('m', 'b', 'r', {}, [])
     self._MockUrlFetch(
         None, json.dumps(try_job.ToBuildbucketRequest()), json.dumps(response))
     results = buildbucket_client.TriggerTryJobs([try_job])
     self.assertEqual(1, len(results))
     error, build = results[0]
     self.assertIsNotNone(error)
     self.assertEqual('error', error.reason)
     self.assertEqual('message', error.message)
@@ skipping 28 matching lines @@
         '1', None, json.dumps(response))
     results = buildbucket_client.GetTryJobs(['1'])
     self.assertEqual(1, len(results))
     error, build = results[0]
     self.assertIsNone(error)
     self.assertIsNotNone(build)
     self.assertEqual('1', build.id)
     self.assertEqual('url', build.url)
     self.assertEqual('STARTED', build.status)
 
-    expected_result = [
+    expected_report = [
         ['rev1', 'passed'],
         ['rev2', 'failed']
     ]
-    self.assertEqual(expected_result, build.result)
+    self.assertEqual(expected_report, build.report)
 
   def testGetTryJobsFailure(self):
     response = {
         'error': {
             'reason': 'BUILD_NOT_FOUND',
             'message': 'message',
         }
     }
     self._MockUrlFetch(
         '2', None, json.dumps(response))
     results = buildbucket_client.GetTryJobs(['2'])
     self.assertEqual(1, len(results))
     error, build = results[0]
     self.assertIsNotNone(error)
     self.assertEqual('BUILD_NOT_FOUND', error.reason)
     self.assertEqual('message', error.message)
     self.assertIsNone(build)
 
   def testGetTryJobsRequestFailure(self):
     response = 'Not Found'
     self._MockUrlFetch(
         '3', None, response, 404)
     results = buildbucket_client.GetTryJobs(['3'])
     self.assertEqual(1, len(results))
     error, build = results[0]
     self.assertIsNotNone(error)
     self.assertEqual(404, error.reason)
     self.assertEqual('Not Found', error.message)
     self.assertIsNone(build)