Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(496)

Unified Diff: chrome/android/java/AndroidManifest.xml

Issue 1622743005: Introduce background Download process to android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/app/android/download_main.cc » ('j') | content/app/content_main_runner.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/AndroidManifest.xml
diff --git a/chrome/android/java/AndroidManifest.xml b/chrome/android/java/AndroidManifest.xml
index b21f383843ea300c1ff7495f9142b1e2034eedb8..b39b3005dea431e6249cc79fd19c0187551a87bd 100644
--- a/chrome/android/java/AndroidManifest.xml
+++ b/chrome/android/java/AndroidManifest.xml
@@ -642,6 +642,13 @@ android:value="true" />
android:exported="false" />
{% endfor %}
+ <!-- Background download process, it may outlive chrome if download does not finish
+ when user kills chrome -->
asanka 2016/01/25 16:44:50 Is this comment accurate? And if so, was there con
qinmin 2016/01/25 22:48:23 I think this should be the use case and should be
+ <service android:name="org.chromium.content.app.DownloadProcessService"
+ android:exported="false"
+ android:permission="{{ manifest_package }}.permission.CHILD_SERVICE"
asanka 2016/01/25 16:44:50 Should this be left unset? What protections do we
qinmin 2016/01/25 22:48:23 This specifies that only processes with CHILD_SERV
+ android:process=":download"/>
svaldez 2016/01/25 15:33:43 nit: Reorder to match ordering of previous service
qinmin 2016/01/25 22:48:23 Done.
+
<receiver android:name="org.chromium.chrome.browser.download.DownloadBroadcastReceiver"
android:exported="false">
<intent-filter>
« no previous file with comments | « no previous file | content/app/android/download_main.cc » ('j') | content/app/content_main_runner.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698