Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Side by Side Diff: chrome/android/java/AndroidManifest.xml

Issue 1622743005: Introduce background Download process to android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | content/app/android/download_main.cc » ('j') | content/app/content_main_runner.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <?xml version="1.0" encoding="utf-8"?> 1 <?xml version="1.0" encoding="utf-8"?>
2 <!-- Copyright 2015 The Chromium Authors. All rights reserved. 2 <!-- Copyright 2015 The Chromium Authors. All rights reserved.
3 Use of this source code is governed by a BSD-style license that can be 3 Use of this source code is governed by a BSD-style license that can be
4 found in the LICENSE file. --> 4 found in the LICENSE file. -->
5 5
6 <!-- 6 <!--
7 Note: This is a jinja2 template, processed at build time into the final manifest . 7 Note: This is a jinja2 template, processed at build time into the final manifest .
8 8
9 Blocks denoted with { % block some_name % }foo{ % endblock % } can be overridden 9 Blocks denoted with { % block some_name % }foo{ % endblock % } can be overridden
10 by a child template that "extends" this file. 10 by a child template that "extends" this file.
(...skipping 624 matching lines...) Expand 10 before | Expand all | Expand 10 after
635 <!-- TODO(tedchoc): Omit this for release builds as MultiDex is debug on ly. --> 635 <!-- TODO(tedchoc): Omit this for release builds as MultiDex is debug on ly. -->
636 <meta-data android:name="{{ manifest_package }}{{ privileged_process_nam e }}.ignore_multidex" 636 <meta-data android:name="{{ manifest_package }}{{ privileged_process_nam e }}.ignore_multidex"
637 android:value="true" /> 637 android:value="true" />
638 <service android:name="org.chromium.content.app.PrivilegedProcessService {{ i }}" 638 <service android:name="org.chromium.content.app.PrivilegedProcessService {{ i }}"
639 android:process="{{ privileged_process_name }}" 639 android:process="{{ privileged_process_name }}"
640 android:permission="{{ manifest_package }}.permission.CHILD_SERVICE" 640 android:permission="{{ manifest_package }}.permission.CHILD_SERVICE"
641 android:isolatedProcess="false" 641 android:isolatedProcess="false"
642 android:exported="false" /> 642 android:exported="false" />
643 {% endfor %} 643 {% endfor %}
644 644
645 <!-- Background download process, it may outlive chrome if download does not finish
646 when user kills chrome -->
asanka 2016/01/25 16:44:50 Is this comment accurate? And if so, was there con
qinmin 2016/01/25 22:48:23 I think this should be the use case and should be
647 <service android:name="org.chromium.content.app.DownloadProcessService"
648 android:exported="false"
649 android:permission="{{ manifest_package }}.permission.CHILD_SERVICE"
asanka 2016/01/25 16:44:50 Should this be left unset? What protections do we
qinmin 2016/01/25 22:48:23 This specifies that only processes with CHILD_SERV
650 android:process=":download"/>
svaldez 2016/01/25 15:33:43 nit: Reorder to match ordering of previous service
qinmin 2016/01/25 22:48:23 Done.
651
645 <receiver android:name="org.chromium.chrome.browser.download.DownloadBro adcastReceiver" 652 <receiver android:name="org.chromium.chrome.browser.download.DownloadBro adcastReceiver"
646 android:exported="false"> 653 android:exported="false">
647 <intent-filter> 654 <intent-filter>
648 <action android:name="android.intent.action.DOWNLOAD_NOTIFICATIO N_CLICKED"/> 655 <action android:name="android.intent.action.DOWNLOAD_NOTIFICATIO N_CLICKED"/>
649 </intent-filter> 656 </intent-filter>
650 </receiver> 657 </receiver>
651 658
652 <receiver android:name="org.chromium.base.PowerStatusReceiver"> 659 <receiver android:name="org.chromium.base.PowerStatusReceiver">
653 <intent-filter> 660 <intent-filter>
654 <action android:name="android.intent.action.ACTION_POWER_CONNECT ED"/> 661 <action android:name="android.intent.action.ACTION_POWER_CONNECT ED"/>
(...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after
706 choose the first MediaRouteController that can play it, so the orde r of the list can be important. 713 choose the first MediaRouteController that can play it, so the orde r of the list can be important.
707 The most specific MediaRouteControllers should be listed first, fol lowed by more generic ones. 714 The most specific MediaRouteControllers should be listed first, fol lowed by more generic ones.
708 The downstream manifest replaces this block, and hence replaces the list of media route 715 The downstream manifest replaces this block, and hence replaces the list of media route
709 controllers with its own list. --> 716 controllers with its own list. -->
710 <meta-data android:name="org.chromium.content.browser.REMOTE_MEDIA_PLAYE RS" 717 <meta-data android:name="org.chromium.content.browser.REMOTE_MEDIA_PLAYE RS"
711 android:value="org.chromium.chrome.browser.media.remote.DefaultMedia RouteController"/> 718 android:value="org.chromium.chrome.browser.media.remote.DefaultMedia RouteController"/>
712 719
713 {% endblock %} 720 {% endblock %}
714 </application> 721 </application>
715 </manifest> 722 </manifest>
OLDNEW
« no previous file with comments | « no previous file | content/app/android/download_main.cc » ('j') | content/app/content_main_runner.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698