Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issue 1622673002: Drop implicit types from summaries. (Closed)

Created:
4 years, 11 months ago by Paul Berry
Modified:
4 years, 11 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Drop implicit types from summaries. Previously, implicit types were serialized in the summary as references to `dynamic`. Now, we simply omit the types from the summary and the dynamic type is inferred at resynthesis time. This should reduce the summary size and simplify the implementation of inferred types. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/52386076f5d7bcffb47615ef8b066e70690d4f28

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+202 lines, -320 lines) Patch
M pkg/analyzer/lib/src/summary/format.dart View 33 chunks +33 lines, -111 lines 0 comments Download
M pkg/analyzer/lib/src/summary/resynthesize.dart View 4 chunks +12 lines, -10 lines 0 comments Download
M pkg/analyzer/lib/src/summary/summarize_ast.dart View 10 chunks +5 lines, -43 lines 0 comments Download
M pkg/analyzer/lib/src/summary/summarize_const_expr.dart View 2 chunks +11 lines, -13 lines 0 comments Download
M pkg/analyzer/lib/src/summary/summarize_elements.dart View 5 chunks +6 lines, -28 lines 0 comments Download
M pkg/analyzer/test/src/summary/summary_common.dart View 36 chunks +114 lines, -91 lines 2 comments Download
M pkg/analyzer/tool/summary/idl.dart View 8 chunks +21 lines, -24 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Paul Berry
4 years, 11 months ago (2016-01-22 19:32:22 UTC) #2
scheglov
LGTM https://codereview.chromium.org/1622673002/diff/1/pkg/analyzer/test/src/summary/summary_common.dart File pkg/analyzer/test/src/summary/summary_common.dart (right): https://codereview.chromium.org/1622673002/diff/1/pkg/analyzer/test/src/summary/summary_common.dart#newcode1602 pkg/analyzer/test/src/summary/summary_common.dart:1602: test_constExpr_makeList_untyped() { I try to name tests using ...
4 years, 11 months ago (2016-01-22 19:39:52 UTC) #3
Paul Berry
https://codereview.chromium.org/1622673002/diff/1/pkg/analyzer/test/src/summary/summary_common.dart File pkg/analyzer/test/src/summary/summary_common.dart (right): https://codereview.chromium.org/1622673002/diff/1/pkg/analyzer/test/src/summary/summary_common.dart#newcode1602 pkg/analyzer/test/src/summary/summary_common.dart:1602: test_constExpr_makeList_untyped() { On 2016/01/22 19:39:52, scheglov wrote: > I ...
4 years, 11 months ago (2016-01-22 19:54:39 UTC) #4
Paul Berry
4 years, 11 months ago (2016-01-22 19:57:36 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
52386076f5d7bcffb47615ef8b066e70690d4f28 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698