Drop implicit types from summaries.

pkg/analyzer/lib/src/summary/summarize_elements.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library serialization.elements;
 
 import 'package:analyzer/dart/element/element.dart';
 import 'package:analyzer/dart/element/type.dart';
 import 'package:analyzer/src/dart/element/element.dart';
 import 'package:analyzer/src/dart/element/type.dart';
@@ skipping 422 matching lines @@
   }
 
   /**
    * Serialize the given [executableElement], creating an [UnlinkedExecutable].
    */
   UnlinkedExecutableBuilder serializeExecutable(
       ExecutableElement executableElement) {
     UnlinkedExecutableBuilder b = new UnlinkedExecutableBuilder();
     b.name = executableElement.name;
     b.nameOffset = executableElement.nameOffset;
-    if (executableElement is! ConstructorElement) {
-      if (executableElement.hasImplicitReturnType) {
-        // In strong mode, the variable's static type may have been overwritten
-        // by an inferred type.  In this part of the summary we want to store
-        // the weak mode static type (which is `dynamic`), since the strong
-        // mode static type is fully linked information.
-        b.returnType = serializeTypeRef(
-            librarySerializer.typeProvider.dynamicType, executableElement);
-      } else {
-        b.returnType = serializeTypeRef(
-            executableElement.type.returnType, executableElement);
-      }
+    if (executableElement is! ConstructorElement &&
+        !executableElement.hasImplicitReturnType) {
+      b.returnType = serializeTypeRef(
+          executableElement.type.returnType, executableElement);
     }
     b.typeParameters =
         executableElement.typeParameters.map(serializeTypeParam).toList();
     b.parameters =
         executableElement.type.parameters.map(serializeParam).toList();
     if (executableElement is PropertyAccessorElement) {
       if (executableElement.isGetter) {
         b.kind = UnlinkedExecutableKind.getter;
       } else {
         b.kind = UnlinkedExecutableKind.setter;
       }
     } else if (executableElement is ConstructorElement) {
       b.kind = UnlinkedExecutableKind.constructor;
       b.isConst = executableElement.isConst;
       b.isFactory = executableElement.isFactory;
     } else {
       b.kind = UnlinkedExecutableKind.functionOrMethod;
     }
     b.isAbstract = executableElement.isAbstract;
     b.isStatic = executableElement.isStatic &&
         executableElement.enclosingElement is ClassElement;
-    b.hasImplicitReturnType = executableElement.hasImplicitReturnType;
     b.isExternal = executableElement.isExternal;
     b.documentationComment = serializeDocumentation(executableElement);
     return b;
   }
 
   /**
    * Serialize the given [exportElement] into an [UnlinkedExportNonPublic].
    */
   UnlinkedExportNonPublicBuilder serializeExportNonPublic(
       ExportElement exportElement) {
@@ skipping 53 matching lines @@
         break;
       case ParameterKind.POSITIONAL:
         b.kind = UnlinkedParamKind.positional;
         break;
       case ParameterKind.NAMED:
         b.kind = UnlinkedParamKind.named;
         break;
     }
     b.isInitializingFormal = parameter.isInitializingFormal;
     DartType type = parameter.type;
-    if (parameter.isInitializingFormal && parameter.hasImplicitType) {
-      b.hasImplicitType = true;
-      // We don't store the type of initializing formals that have an implicit
-      // type, because the type is inherited from the field.
-    } else {
+    if (!parameter.hasImplicitType) {
       if (type is FunctionType) {
         b.isFunctionTyped = true;
         b.type = serializeTypeRef(type.returnType, parameter);
         b.parameters = type.parameters
             .map((parameter) => serializeParam(parameter, context))
             .toList();
       } else {
         b.type = serializeTypeRef(type, context);
-        b.hasImplicitType = parameter.hasImplicitType;
       }
     }
     return b;
   }
 
   /**
    * Serialize the given [prefix] into an index into the references table.
    */
   int serializePrefix(PrefixElement element) {
     return referenceMap.putIfAbsent(element, () {
@@ skipping 115 matching lines @@
     return unresolvedReferenceIndex;
   }
 
   /**
    * Serialize the given [variable], creating an [UnlinkedVariable].
    */
   UnlinkedVariableBuilder serializeVariable(PropertyInducingElement variable) {
     UnlinkedVariableBuilder b = new UnlinkedVariableBuilder();
     b.name = variable.name;
     b.nameOffset = variable.nameOffset;
-    if (variable.hasImplicitType) {
-      // In strong mode, the variable's static type may have been overwritten
-      // by an inferred type.  In this part of the summary we want to store the
-      // weak mode static type (which is `dynamic`), since the strong mode
-      // static type is fully linked information.
-      b.type = serializeTypeRef(
-          librarySerializer.typeProvider.dynamicType, variable);
-    } else {
+    if (!variable.hasImplicitType) {
       b.type = serializeTypeRef(variable.type, variable);
     }
     b.isStatic = variable.isStatic && variable.enclosingElement is ClassElement;
     b.isFinal = variable.isFinal;
     b.isConst = variable.isConst;
-    b.hasImplicitType = variable.hasImplicitType;
     b.documentationComment = serializeDocumentation(variable);
     if (variable.isConst && variable is ConstVariableElement) {
       ConstVariableElement constVariable = variable as ConstVariableElement;
       Expression initializer = constVariable.constantInitializer;
       if (initializer != null) {
         b.constExpr = serializeConstExpr(initializer);
       }
     }
     if (b.isFinal || b.isConst) {
       b.propagatedTypeSlot = storeLinkedType(variable.propagatedType, variable);
@@ skipping 272 matching lines @@
       exportNames.add(new LinkedExportNameBuilder(
           name: name,
           dependency: serializeDependency(dependentLibrary),
           unit: unit,
           kind: kind));
     }
     pb.exportNames = exportNames;
     return pb;
   }
 }