chrome/browser/engagement/site_engagement_service.h - Issue 1622413002: Update user input event's engagement value.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/engagement/site_engagement_service.h

Issue 1622413002: Update user input event's engagement value. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@first_nav_bonus

Patch Set: address nits Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/engagement/site_engagement_helper_unittest.cc ('k') | chrome/browser/engagement/site_engagement_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/engagement/site_engagement_service.h

diff --git a/chrome/browser/engagement/site_engagement_service.h b/chrome/browser/engagement/site_engagement_service.h

index efdcc7996cb984a95faf3e9ddb983daacdaf4a33..5c9156ceba449e125eb794c7a1dbf4a2a8c6e88d 100644

--- a/chrome/browser/engagement/site_engagement_service.h

+++ b/chrome/browser/engagement/site_engagement_service.h

@@ -132,7 +132,9 @@ class SiteEngagementScore {

// Determine any score bonus from having installed shortcuts.

double BonusScore() const;

- static void DisableFirstDailyEngagementBonusForTesting();

+ // Sets fixed parameter values for testing site engagement. Ensure that any

+ // newly added parameters receive a fixed value here.

+ static void SetParamValuesForTesting();

// The clock used to vend times. Enables time travelling in tests. Owned by

// the SiteEngagementService.