Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(817)

Unified Diff: chrome/browser/engagement/site_engagement_service.cc

Issue 1622413002: Update user input event's engagement value. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@first_nav_bonus
Patch Set: address nits Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/engagement/site_engagement_service.cc
diff --git a/chrome/browser/engagement/site_engagement_service.cc b/chrome/browser/engagement/site_engagement_service.cc
index 8b3a26405e3f25c69df28c98b929404d520faf18..ba0e74dd54de955f2aa1a583b897e198d336ad7b 100644
--- a/chrome/browser/engagement/site_engagement_service.cc
+++ b/chrome/browser/engagement/site_engagement_service.cc
@@ -121,7 +121,7 @@ double SiteEngagementScore::param_values[] = {
7, // DECAY_PERIOD_IN_DAYS
5, // DECAY_POINTS
0.5, // NAVIGATION_POINTS
- 0.05, // USER_INPUT_POINTS
+ 0.2, // USER_INPUT_POINTS
0.02, // VISIBLE_MEDIA_POINTS
0.01, // HIDDEN_MEDIA_POINTS
5, // WEB_APP_INSTALLED_POINTS
@@ -325,7 +325,18 @@ double SiteEngagementScore::BonusScore() const {
return 0;
}
-void SiteEngagementScore::DisableFirstDailyEngagementBonusForTesting() {
+void SiteEngagementScore::SetParamValuesForTesting() {
+ param_values[MAX_POINTS_PER_DAY] = 5;
+ param_values[DECAY_PERIOD_IN_DAYS] = 7;
+ param_values[DECAY_POINTS] = 5;
+ param_values[NAVIGATION_POINTS] = 0.5;
+ param_values[USER_INPUT_POINTS] = 0.05;
+ param_values[VISIBLE_MEDIA_POINTS] = 0.02;
+ param_values[HIDDEN_MEDIA_POINTS] = 0.01;
+ param_values[WEB_APP_INSTALLED_POINTS] = 5;
+
+ // This is set to zero to avoid interference with tests and is set when
+ // testing this functionality.
param_values[FIRST_DAILY_ENGAGEMENT] = 0;
}
« no previous file with comments | « chrome/browser/engagement/site_engagement_service.h ('k') | chrome/browser/engagement/site_engagement_service_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698