Update user input event's engagement value.

Update user input event's engagement value.

This CL updates the site engagement service's score value for user input
events. In order to maintain compatibility with current tests, old score
values that are used for testing have been hard coded into
SiteEngagementService.

BUG=464234
Committed: https://crrev.com/28d2d74c43131e4c85cc96e3f1c79b3c6962f397
Cr-Commit-Position: refs/heads/master@{#371714}

[calamity, 2016-01-25 02:56:04]

calamity@chromium.org changed reviewers:
+ dominickn@chromium.org

[dominickn, 2016-01-25 03:04:57]

lgtm % nits

https://codereview.chromium.org/1622413002/diff/1/chrome/browser/engagement/s...
File chrome/browser/engagement/site_engagement_service.cc (right):

https://codereview.chromium.org/1622413002/diff/1/chrome/browser/engagement/s...
chrome/browser/engagement/site_engagement_service.cc:337:
param_values[FIRST_DAILY_ENGAGEMENT] = 0;
Nit: add a comment pointing out that first daily engagement is explicitly 0 to
not interfere with testing, and its value is changed when needed.

https://codereview.chromium.org/1622413002/diff/1/chrome/browser/engagement/s...
File chrome/browser/engagement/site_engagement_service.h (right):

https://codereview.chromium.org/1622413002/diff/1/chrome/browser/engagement/s...
chrome/browser/engagement/site_engagement_service.h:134: 
Nit: add a comment along the lines of "Sets fixed parameter values for testing
site engagement. Ensure that any new parameters receive a fixed value here."
Just to ensure that future changes to site engagement don't miss this testing
wrinkle.

[calamity, 2016-01-27 03:47:23]

https://codereview.chromium.org/1622413002/diff/1/chrome/browser/engagement/s...
File chrome/browser/engagement/site_engagement_service.cc (right):

https://codereview.chromium.org/1622413002/diff/1/chrome/browser/engagement/s...
chrome/browser/engagement/site_engagement_service.cc:337:
param_values[FIRST_DAILY_ENGAGEMENT] = 0;
On 2016/01/25 03:04:57, dominickn wrote:
> Nit: add a comment pointing out that first daily engagement is explicitly 0 to
> not interfere with testing, and its value is changed when needed.

Done.

https://codereview.chromium.org/1622413002/diff/1/chrome/browser/engagement/s...
File chrome/browser/engagement/site_engagement_service.h (right):

https://codereview.chromium.org/1622413002/diff/1/chrome/browser/engagement/s...
chrome/browser/engagement/site_engagement_service.h:134: 
On 2016/01/25 03:04:57, dominickn wrote:
> Nit: add a comment along the lines of "Sets fixed parameter values for testing
> site engagement. Ensure that any new parameters receive a fixed value here."
> Just to ensure that future changes to site engagement don't miss this testing
> wrinkle.

Done.

[calamity, 2016-01-27 03:47:52]

The CQ bit was checked by calamity@chromium.org

[calamity, 2016-01-27 03:47:53]

The patchset sent to the CQ was uploaded after l-g-t-m from
dominickn@chromium.org
Link to the patchset: https://codereview.chromium.org/1622413002/#ps20001
(title: "address nits")

[commit-bot: I haz the power, 2016-01-27 03:49:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1622413002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1622413002/20001

[commit-bot: I haz the power, 2016-01-27 03:55:29]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-01-27 03:56:33]

Description was changed from

==========
Update user input event's engagement value.

This CL updates the site engagement service's score value for user input
events. In order to maintain compatibility with current tests, old score
values that are used for testing have been hard coded into
SiteEngagementService.

BUG=464234
==========

to

==========
Update user input event's engagement value.

This CL updates the site engagement service's score value for user input
events. In order to maintain compatibility with current tests, old score
values that are used for testing have been hard coded into
SiteEngagementService.

BUG=464234

Committed: https://crrev.com/28d2d74c43131e4c85cc96e3f1c79b3c6962f397
Cr-Commit-Position: refs/heads/master@{#371714}
==========

[commit-bot: I haz the power, 2016-01-27 03:56:34]

Patchset 2 (id:??) landed as
https://crrev.com/28d2d74c43131e4c85cc96e3f1c79b3c6962f397
Cr-Commit-Position: refs/heads/master@{#371714}