Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(856)

Unified Diff: webkit/glue/form_field.cc

Issue 1622004: AutoFill: Parse HTMLLabel elements for form control element labels. (Closed)
Patch Set: Update constness. Created 10 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/render_view.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/glue/form_field.cc
diff --git a/webkit/glue/form_field.cc b/webkit/glue/form_field.cc
index cddd538616cc67d00b5cd1ef3257c660c0588315..a82283aa3b7896357591ae59fcbd6a62b2728b11 100644
--- a/webkit/glue/form_field.cc
+++ b/webkit/glue/form_field.cc
@@ -53,9 +53,8 @@ FormField::FormField(const string16& label,
bool FormField::operator==(const FormField& field) const {
// A FormField stores a value, but the value is not part of the identity of
// the field, so we don't want to compare the values.
- // TODO(jhawkins): Re-enable checking the field label for == once we parse
- // labels again.
- return (name_ == field.name_ &&
+ return (label_ == field.label_ &&
+ name_ == field.name_ &&
form_control_type_ == field.form_control_type_);
}
« no previous file with comments | « chrome/renderer/render_view.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698