source/common/stringpiece.cpp - Issue 1621843002: ICU 56 update step 1 - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(12)

My Issues | Starred Open | Closed | All

Unified Diff: source/common/stringpiece.cpp

Issue 1621843002: ICU 56 update step 1 (Closed) Base URL: https://chromium.googlesource.com/chromium/deps/icu.git@561

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« no previous file with comments | « source/common/simplepatternformatter.cpp ('k') | source/common/ubidi_props_data.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: source/common/stringpiece.cpp

diff --git a/source/common/stringpiece.cpp b/source/common/stringpiece.cpp

index 007713e6f8f30310c612f52dc607e548a87bb9b7..0fb2b3e54cbff90499b21c04661e012a4e781fb9 100644

--- a/source/common/stringpiece.cpp

+++ b/source/common/stringpiece.cpp

@@ -68,14 +68,6 @@ operator==(const StringPiece& x, const StringPiece& y) {

}

-/* Microsoft Visual Studio (even 2013) complains about redefinition of this

- * static const class variable. However, the C++ standard states that this

- * definition is correct. Perhaps there is a bug in the Microsoft compiler.

- * This is not an issue on any other compilers (that we know of).

- * Cygwin with MSVC 9.0 also complains here about redefinition.

- */

-#if (!defined(_MSC_VER) || (_MSC_VER > 1800)) && !defined(CYGWINMSVC)

const int32_t StringPiece::npos = 0x7fffffff;

-#endif

U_NAMESPACE_END

« no previous file with comments | « source/common/simplepatternformatter.cpp ('k') | source/common/ubidi_props_data.h » ('j') | no next file with comments »

Powered by Google App Engine

This is Rietveld 408576698