source/common/stringpiece.cpp - Issue 1621843002: ICU 56 update step 1

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: source/common/stringpiece.cpp

Issue 1621843002: ICU 56 update step 1 (Closed) Base URL: https://chromium.googlesource.com/chromium/deps/icu.git@561

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright (C) 2009-2013, International Business Machines	1 // Copyright (C) 2009-2013, International Business Machines

2 // Corporation and others. All Rights Reserved.	2 // Corporation and others. All Rights Reserved.

3 //	3 //

4 // Copyright 2004 and onwards Google Inc.	4 // Copyright 2004 and onwards Google Inc.

5 //	5 //

6 // Author: wilsonh@google.com (Wilson Hsieh)	6 // Author: wilsonh@google.com (Wilson Hsieh)

7 //	7 //

8	8

9 #include "unicode/utypes.h"	9 #include "unicode/utypes.h"

10 #include "unicode/stringpiece.h"	10 #include "unicode/stringpiece.h"

(...skipping 50 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
61 const char* p = x.data();	61 const char* p = x.data();

62 const char* p2 = y.data();	62 const char* p2 = y.data();

63 // Test last byte in case strings share large common prefix	63 // Test last byte in case strings share large common prefix

64 --len;	64 --len;

65 if (p[len] != p2[len]) return false;	65 if (p[len] != p2[len]) return false;

66 // At this point we can, but don't have to, ignore the last byte.	66 // At this point we can, but don't have to, ignore the last byte.

67 return uprv_memcmp(p, p2, len) == 0;	67 return uprv_memcmp(p, p2, len) == 0;

68 }	68 }

69	69

70	70

71 /* Microsoft Visual Studio (even 2013) complains about redefinition of this

72 * static const class variable. However, the C++ standard states that this

73 * definition is correct. Perhaps there is a bug in the Microsoft compiler.

74 * This is not an issue on any other compilers (that we know of).

75 * Cygwin with MSVC 9.0 also complains here about redefinition.

76 */

77 #if (!defined(_MSC_VER) \|\| (_MSC_VER > 1800)) && !defined(CYGWINMSVC)

78 const int32_t StringPiece::npos = 0x7fffffff;	71 const int32_t StringPiece::npos = 0x7fffffff;

79 #endif

80	72

81 U_NAMESPACE_END	73 U_NAMESPACE_END

OLD	NEW

« no previous file with comments | « source/common/simplepatternformatter.cpp ('k') | source/common/ubidi_props_data.h » ('j') | no next file with comments »