Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Unified Diff: pkg/analyzer/test/src/summary/summary_common.dart

Issue 1621763002: Use the explicit string 'dynamic' to refer to dynamic in summaries. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/lib/src/summary/summarize_elements.dart ('k') | pkg/analyzer/tool/summary/idl.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/test/src/summary/summary_common.dart
diff --git a/pkg/analyzer/test/src/summary/summary_common.dart b/pkg/analyzer/test/src/summary/summary_common.dart
index a5756e7f7c548527773cc8926cd3c24a052ad68a..f1a320f79079acb25d97c056c0c6288104fb828c 100644
--- a/pkg/analyzer/test/src/summary/summary_common.dart
+++ b/pkg/analyzer/test/src/summary/summary_common.dart
@@ -236,7 +236,7 @@ abstract class SummaryTest {
* Verify that the given [typeRef] represents the type `dynamic`.
*/
void checkDynamicTypeRef(EntityRef typeRef) {
- checkTypeRef(typeRef, null, null, null);
+ checkTypeRef(typeRef, null, null, 'dynamic');
}
/**
@@ -506,10 +506,8 @@ abstract class SummaryTest {
// [LinkedUnit.references].
name = referenceResolution.name;
}
- if (referenceIndex == 0) {
- // Index 0 is reserved for "dynamic".
- expect(name, isEmpty);
- }
+ // Index 0 is reserved.
+ expect(referenceIndex, isNot(0));
if (absoluteUri == null) {
expect(referenceResolution.dependency, 0);
} else {
@@ -1594,8 +1592,7 @@ const v = const C(11, 22, 3.3, '444', e: 55, g: '777', f: 66);
33,
3
], referenceValidators: [
- (EntityRef r) => checkTypeRef(r, null, null, '',
- expectedKind: ReferenceKind.classOrEnum)
+ (EntityRef r) => checkDynamicTypeRef(r)
]);
}
@@ -1648,10 +1645,8 @@ const v = const C(11, 22, 3.3, '444', e: 55, g: '777', f: 66);
'bbb',
'ccc'
], referenceValidators: [
- (EntityRef r) => checkTypeRef(r, null, null, '',
- expectedKind: ReferenceKind.classOrEnum),
- (EntityRef r) => checkTypeRef(r, null, null, '',
- expectedKind: ReferenceKind.classOrEnum)
+ (EntityRef r) => checkDynamicTypeRef(r),
+ (EntityRef r) => checkDynamicTypeRef(r)
]);
}
« no previous file with comments | « pkg/analyzer/lib/src/summary/summarize_elements.dart ('k') | pkg/analyzer/tool/summary/idl.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698