Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(575)

Unified Diff: pkg/analyzer/tool/summary/idl.dart

Issue 1621763002: Use the explicit string 'dynamic' to refer to dynamic in summaries. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/test/src/summary/summary_common.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/tool/summary/idl.dart
diff --git a/pkg/analyzer/tool/summary/idl.dart b/pkg/analyzer/tool/summary/idl.dart
index 337280fe0e1500dd2a8b0d85cd79b56562215518..1753bc20074f56f9eaf42b69d32520f22c8406bf 100644
--- a/pkg/analyzer/tool/summary/idl.dart
+++ b/pkg/analyzer/tool/summary/idl.dart
@@ -83,12 +83,6 @@ class EntityRef {
/**
* Index into [UnlinkedUnit.references] for the entity being referred to, or
* zero if this is a reference to a type parameter.
- *
- * Note that since zero is also a valid index into
- * [UnlinkedUnit.references], we cannot distinguish between references to
- * type parameters and references to other entities by checking [reference]
- * against zero. To distinguish between references to type parameters and
- * references to other entities, check whether [paramReference] is zero.
*/
int reference;
@@ -258,8 +252,8 @@ class LinkedReference {
/**
* If this [LinkedReference] doesn't have an associated [UnlinkedReference],
- * name of the entity being referred to. The empty string refers to the
- * pseudo-type `dynamic`.
+ * name of the entity being referred to. For the pseudo-type `dynamic`, the
+ * string is "dynamic".
*/
String name;
}
@@ -1201,8 +1195,8 @@ class UnlinkedPublicNamespace {
*/
class UnlinkedReference {
/**
- * Name of the entity being referred to. The empty string refers to the
- * pseudo-type `dynamic`.
+ * Name of the entity being referred to. For the pseudo-type `dynamic`, the
+ * string is "dynamic".
*/
String name;
@@ -1315,8 +1309,10 @@ class UnlinkedUnit {
/**
* Top level and prefixed names referred to by this compilation unit. The
- * zeroth element of this array is always populated and always represents a
- * reference to the pseudo-type "dynamic".
+ * zeroth element of this array is always populated and is used to represent
+ * the absence of a reference in places where a reference is optional (for
+ * example [UnlinkedReference.prefixReference or
+ * UnlinkedImport.prefixReference]).
*/
List<UnlinkedReference> references;
« no previous file with comments | « pkg/analyzer/test/src/summary/summary_common.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698