Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 1621763002: Use the explicit string 'dynamic' to refer to dynamic in summaries. (Closed)

Created:
4 years, 11 months ago by Paul Berry
Modified:
4 years, 11 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use the explicit string 'dynamic' to refer to dynamic in summaries. Previously we used reference 0 as a special case to mean "dynamic". This saved a tiny amount of space in the summary file, but it's not worth it because it will complicate some error handling scenarios (which will be addressed in future CLs). This CL changes "dynamic" so that it's serialized as though it were defined in the defining compilation unit of each library. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/ef3935b5909e6485d4eaee1ea4e122fe3e005126

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -71 lines) Patch
M pkg/analyzer/lib/src/summary/format.dart View 8 chunks +16 lines, -24 lines 0 comments Download
M pkg/analyzer/lib/src/summary/prelink.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/summary/resynthesize.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/summary/summarize_ast.dart View 4 chunks +5 lines, -5 lines 0 comments Download
M pkg/analyzer/lib/src/summary/summarize_elements.dart View 4 chunks +16 lines, -17 lines 0 comments Download
M pkg/analyzer/test/src/summary/summary_common.dart View 4 chunks +6 lines, -11 lines 0 comments Download
M pkg/analyzer/tool/summary/idl.dart View 4 chunks +8 lines, -12 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
4 years, 11 months ago (2016-01-22 16:34:21 UTC) #2
scheglov
LGTM
4 years, 11 months ago (2016-01-22 17:49:50 UTC) #3
Paul Berry
4 years, 11 months ago (2016-01-22 17:57:06 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ef3935b5909e6485d4eaee1ea4e122fe3e005126 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698