Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Issue 1621623002: [crankshaft] For-in index increment cannot overflow. (Closed)

Created:
4 years, 11 months ago by Benedikt Meurer
Modified:
4 years, 11 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@FLAG_optimize_for_in
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[crankshaft] For-in index increment cannot overflow. The internal index used to implement for-in can never leave the valid smi range, so there's no need to actually check for overflow in Crankshaft. In fact the overflow only triggered a false alert in the deopt fuzzer. R=jarin@chromium.org BUG=v8:3650 LOG=n Committed: https://crrev.com/c7d2adc0a28c7eb83bb0ce898235b760cb01d394 Cr-Commit-Position: refs/heads/master@{#33456}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -1 line) Patch
M src/crankshaft/hydrogen.cc View 1 chunk +4 lines, -1 line 0 comments Download
A test/mjsunit/regress/regress-3650-1.js View 1 chunk +22 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
4 years, 11 months ago (2016-01-22 06:30:33 UTC) #1
Benedikt Meurer
Hey Jaro, Here's the fix for the deopt fuzzer. Please take a look. Thanks, Benedikt
4 years, 11 months ago (2016-01-22 06:31:17 UTC) #2
Jarin
lgtm
4 years, 11 months ago (2016-01-22 07:52:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1621623002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1621623002/1
4 years, 11 months ago (2016-01-22 07:53:33 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-22 07:54:47 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-22 07:55:16 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c7d2adc0a28c7eb83bb0ce898235b760cb01d394
Cr-Commit-Position: refs/heads/master@{#33456}

Powered by Google App Engine
This is Rietveld 408576698