Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1621583002: [crankshaft] Remove useless --optimize-for-in flag. (Closed)

Created:
4 years, 11 months ago by Benedikt Meurer
Modified:
4 years, 11 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com, Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[crankshaft] Remove useless --optimize-for-in flag. R=jarin@chromium.org BUG=v8:3650 LOG=n Committed: https://crrev.com/721a64ac933ebf94454e0fa8ac529ef7ccd7fd22 Cr-Commit-Position: refs/heads/master@{#33453}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -10 lines) Patch
M src/bailout-reason.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/crankshaft/hydrogen.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +0 lines, -2 lines 0 comments Download
M test/mjsunit/compiler/optimized-for-in.js View 1 chunk +1 line, -2 lines 0 comments Download

Dependent Patchsets:

Issue 1621623002 Patch 1

Messages

Total messages: 7 (2 generated)
Benedikt Meurer
4 years, 11 months ago (2016-01-22 05:30:07 UTC) #1
Jarin
lgtm
4 years, 11 months ago (2016-01-22 05:38:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1621583002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1621583002/1
4 years, 11 months ago (2016-01-22 05:38:23 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-22 06:25:15 UTC) #5
commit-bot: I haz the power
4 years, 11 months ago (2016-01-22 06:26:23 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/721a64ac933ebf94454e0fa8ac529ef7ccd7fd22
Cr-Commit-Position: refs/heads/master@{#33453}

Powered by Google App Engine
This is Rietveld 408576698