Issue 1620813005: Revert of Move remote_db_manager into the safe_browsing_db component.

Issue 1620813005: Revert of Move remote_db_manager into the safe_browsing_db component. (Closed)

Created:
4 years, 11 months ago by Scott Hess - ex-Googler

Modified:
4 years, 11 months ago

Reviewers:
Nathan Parker, vakh (use Gerrit instead), jochen (gone - plz use gerrit), blundell

CC:
asanka, blundell+watchlist_chromium.org, cbentzel+watch_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, davidben+watch_chromium.org, droger+watchlist_chromium.org, extensions-reviews_chromium.org, gavinp+prer_chromium.org, grt+watch_chromium.org, sdefresne+watchlist_chromium.org, tburkard+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Revert of Move remote_db_manager into the safe_browsing_db component. (patchset #17 id:300001 of https://codereview.chromium.org/1579403002/ ) Reason for revert: "buildbot failure in Chromium on Win" components\safe_browsing_db\safe_browsing_api_handler_util.cc(138) : error C2220: warning treated as error - no 'object' file generated components\safe_browsing_db\safe_browsing_api_handler_util.cc(138) : warning C4701: potentially uninitialized local variable 'matches' used components\safe_browsing_db\safe_browsing_api_handler_util.cc(138) : warning C4703: potentially uninitialized local pointer variable 'matches' used Original issue's description: > Move remote_db_manager into the safe_browsing_db component. > > BUG=543161 > > Committed: https://crrev.com/bdd302affda19c5b2051d1e868c7045f5614c955 > Cr-Commit-Position: refs/heads/master@{#371034} TBR=jochen@chromium.org,blundell@chromium.org,nparker@chromium.org,vakh@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=543161 Committed: https://crrev.com/2b17e4a37d9c71a1cafdb77688fe344a5034341c Cr-Commit-Position: refs/heads/master@{#371050}

Patch Set 1 #

Created: 4 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+950 lines, -1077 lines)			Patch
M	chrome/BUILD.gn	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/app/DEPS	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/app/android/chrome_main_delegate_android.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/BUILD.gn	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	chrome/browser/chromeos/BUILD.gn	View	2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/safe_browsing/BUILD.gn	View	1 chunk	+7 lines, -0 lines	0 comments	Download
A	chrome/browser/safe_browsing/metadata.proto	View	1 chunk	+23 lines, -0 lines	0 comments	Download
A	chrome/browser/safe_browsing/remote_database_manager.h	View	1 chunk	+80 lines, -0 lines	0 comments	Download
A	chrome/browser/safe_browsing/remote_database_manager.cc	View	1 chunk	+285 lines, -0 lines	0 comments	Download
A	chrome/browser/safe_browsing/remote_database_manager_unittest.cc	View	1 chunk	+103 lines, -0 lines	0 comments	Download
A	chrome/browser/safe_browsing/safe_browsing_api_handler.h	View	1 chunk	+43 lines, -0 lines	0 comments	Download
A	chrome/browser/safe_browsing/safe_browsing_api_handler.cc	View	1 chunk	+21 lines, -0 lines	0 comments	Download
A	chrome/browser/safe_browsing/safe_browsing_api_handler_unittest.cc	View	1 chunk	+123 lines, -0 lines	0 comments	Download
A	chrome/browser/safe_browsing/safe_browsing_api_handler_util.h	View	1 chunk	+58 lines, -0 lines	0 comments	Download
A	chrome/browser/safe_browsing/safe_browsing_api_handler_util.cc	View	1 chunk	+167 lines, -0 lines	0 comments	Download
M	chrome/browser/safe_browsing/safe_browsing_service.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc	View	2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/safe_browsing/ui_manager.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/chrome_android.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/chrome_browser.gypi	View	4 chunks	+20 lines, -2 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/chrome_tests_unit.gypi	View	2 chunks	+7 lines, -1 line	0 comments	Download
M	chrome/test/BUILD.gn	View	1 chunk	+1 line, -1 line	0 comments	Download
M	components/BUILD.gn	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	components/components_tests.gyp	View	2 chunks	+0 lines, -12 lines	0 comments	Download
M	components/safe_browsing_db.gypi	View	2 chunks	+2 lines, -53 lines	0 comments	Download
M	components/safe_browsing_db/BUILD.gn	View	3 chunks	+1 line, -85 lines	0 comments	Download
M	components/safe_browsing_db/DEPS	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	components/safe_browsing_db/hit_report.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
D	components/safe_browsing_db/metadata.proto	View	1 chunk	+0 lines, -23 lines	0 comments	Download
D	components/safe_browsing_db/remote_database_manager.h	View	1 chunk	+0 lines, -80 lines	0 comments	Download
D	components/safe_browsing_db/remote_database_manager.cc	View	1 chunk	+0 lines, -286 lines	0 comments	Download
D	components/safe_browsing_db/remote_database_manager_unittest.cc	View	1 chunk	+0 lines, -103 lines	0 comments	Download
D	components/safe_browsing_db/safe_browsing_api_handler.h	View	1 chunk	+0 lines, -43 lines	0 comments	Download
D	components/safe_browsing_db/safe_browsing_api_handler.cc	View	1 chunk	+0 lines, -21 lines	0 comments	Download
D	components/safe_browsing_db/safe_browsing_api_handler_unittest.cc	View	1 chunk	+0 lines, -123 lines	0 comments	Download
D	components/safe_browsing_db/safe_browsing_api_handler_util.h	View	1 chunk	+0 lines, -58 lines	0 comments	Download
D	components/safe_browsing_db/safe_browsing_api_handler_util.cc	View	1 chunk	+0 lines, -164 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Scott Hess - ex-Googler

Created Revert of Move remote_db_manager into the safe_browsing_db component.

4 years, 11 months ago (2016-01-22 21:47:05 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1620813005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1620813005/1

4 years, 11 months ago (2016-01-22 21:48:14 UTC) #2

commit-bot: I haz the power

Description was changed from ========== Revert of Move remote_db_manager into the safe_browsing_db component. (patchset #17 ...

4 years, 11 months ago (2016-01-22 21:50:51 UTC) #3

Message was sent while issue was closed.

Description was changed from

==========
Revert of Move remote_db_manager into the safe_browsing_db component. (patchset
#17 id:300001 of https://codereview.chromium.org/1579403002/ )

Reason for revert:
"buildbot failure in Chromium on Win"

components\safe_browsing_db\safe_browsing_api_handler_util.cc(138) : error
C2220: warning treated as error - no 'object' file generated
components\safe_browsing_db\safe_browsing_api_handler_util.cc(138) : warning
C4701: potentially uninitialized local variable 'matches' used
components\safe_browsing_db\safe_browsing_api_handler_util.cc(138) : warning
C4703: potentially uninitialized local pointer variable 'matches' used


Original issue's description:
> Move remote_db_manager into the safe_browsing_db component.
> 
> BUG=543161
> 
> Committed: https://crrev.com/bdd302affda19c5b2051d1e868c7045f5614c955
> Cr-Commit-Position: refs/heads/master@{#371034}

TBR=jochen@chromium.org,blundell@chromium.org,nparker@chromium.org,vakh@chrom...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=543161
==========

to

==========
Revert of Move remote_db_manager into the safe_browsing_db component. (patchset
#17 id:300001 of https://codereview.chromium.org/1579403002/ )

Reason for revert:
"buildbot failure in Chromium on Win"

components\safe_browsing_db\safe_browsing_api_handler_util.cc(138) : error
C2220: warning treated as error - no 'object' file generated
components\safe_browsing_db\safe_browsing_api_handler_util.cc(138) : warning
C4701: potentially uninitialized local variable 'matches' used
components\safe_browsing_db\safe_browsing_api_handler_util.cc(138) : warning
C4703: potentially uninitialized local pointer variable 'matches' used


Original issue's description:
> Move remote_db_manager into the safe_browsing_db component.
> 
> BUG=543161
> 
> Committed: https://crrev.com/bdd302affda19c5b2051d1e868c7045f5614c955
> Cr-Commit-Position: refs/heads/master@{#371034}

TBR=jochen@chromium.org,blundell@chromium.org,nparker@chromium.org,vakh@chrom...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=543161
==========

commit-bot: I haz the power

Description was changed from ========== Revert of Move remote_db_manager into the safe_browsing_db component. (patchset #17 ...

4 years, 11 months ago (2016-01-22 21:52:31 UTC) #5

Message was sent while issue was closed.

Description was changed from

==========
Revert of Move remote_db_manager into the safe_browsing_db component. (patchset
#17 id:300001 of https://codereview.chromium.org/1579403002/ )

Reason for revert:
"buildbot failure in Chromium on Win"

components\safe_browsing_db\safe_browsing_api_handler_util.cc(138) : error
C2220: warning treated as error - no 'object' file generated
components\safe_browsing_db\safe_browsing_api_handler_util.cc(138) : warning
C4701: potentially uninitialized local variable 'matches' used
components\safe_browsing_db\safe_browsing_api_handler_util.cc(138) : warning
C4703: potentially uninitialized local pointer variable 'matches' used


Original issue's description:
> Move remote_db_manager into the safe_browsing_db component.
> 
> BUG=543161
> 
> Committed: https://crrev.com/bdd302affda19c5b2051d1e868c7045f5614c955
> Cr-Commit-Position: refs/heads/master@{#371034}

TBR=jochen@chromium.org,blundell@chromium.org,nparker@chromium.org,vakh@chrom...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=543161
==========

to

==========
Revert of Move remote_db_manager into the safe_browsing_db component. (patchset
#17 id:300001 of https://codereview.chromium.org/1579403002/ )

Reason for revert:
"buildbot failure in Chromium on Win"

components\safe_browsing_db\safe_browsing_api_handler_util.cc(138) : error
C2220: warning treated as error - no 'object' file generated
components\safe_browsing_db\safe_browsing_api_handler_util.cc(138) : warning
C4701: potentially uninitialized local variable 'matches' used
components\safe_browsing_db\safe_browsing_api_handler_util.cc(138) : warning
C4703: potentially uninitialized local pointer variable 'matches' used

Original issue's description:
> Move remote_db_manager into the safe_browsing_db component.
>
> BUG=543161
>
> Committed: https://crrev.com/bdd302affda19c5b2051d1e868c7045f5614c955
> Cr-Commit-Position: refs/heads/master@{#371034}

TBR=jochen@chromium.org,blundell@chromium.org,nparker@chromium.org,vakh@chrom...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=543161

Committed: https://crrev.com/2b17e4a37d9c71a1cafdb77688fe344a5034341c
Cr-Commit-Position: refs/heads/master@{#371050}
==========

commit-bot: I haz the power

4 years, 11 months ago (2016-01-22 21:52:32 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/2b17e4a37d9c71a1cafdb77688fe344a5034341c
Cr-Commit-Position: refs/heads/master@{#371050}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages