Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Unified Diff: chrome/browser/safe_browsing/remote_database_manager_unittest.cc

Issue 1620813005: Revert of Move remote_db_manager into the safe_browsing_db component. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/remote_database_manager_unittest.cc
diff --git a/chrome/browser/safe_browsing/remote_database_manager_unittest.cc b/chrome/browser/safe_browsing/remote_database_manager_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..e58411831bd9e3f89c4f07287d4a6efb84a6c1f7
--- /dev/null
+++ b/chrome/browser/safe_browsing/remote_database_manager_unittest.cc
@@ -0,0 +1,103 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/logging.h"
+#include "base/memory/scoped_ptr.h"
+#include "base/metrics/field_trial.h"
+#include "base/strings/stringprintf.h"
+#include "base/time/time.h"
+#include "chrome/browser/safe_browsing/remote_database_manager.h"
+#include "chrome/browser/safe_browsing/safe_browsing_api_handler.h"
+#include "components/variations/variations_associated_data.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace safe_browsing {
+
+namespace {
+
+class TestSafeBrowsingApiHandler : public SafeBrowsingApiHandler {
+ public:
+ void StartURLCheck(const URLCheckCallback& callback,
+ const GURL& url,
+ const std::vector<SBThreatType>& threat_types) override {}
+};
+
+} // namespace
+
+class RemoteDatabaseManagerTest : public testing::Test {
+ protected:
+ RemoteDatabaseManagerTest() : field_trials_(new base::FieldTrialList(NULL)) {}
+
+ void SetUp() override {
+ SafeBrowsingApiHandler::SetInstance(&api_handler_);
+ db_ = new RemoteSafeBrowsingDatabaseManager();
+ }
+
+ // Setup the two field trial params. These are read in db_'s ctor.
+ void SetFieldTrialParams(const std::string types_to_check_val) {
+ // Destroy the existing FieldTrialList before creating a new one to avoid
+ // a DCHECK.
+ field_trials_.reset();
+ field_trials_.reset(new base::FieldTrialList(NULL));
+ variations::testing::ClearAllVariationIDs();
+ variations::testing::ClearAllVariationParams();
+
+ const std::string group_name = "GroupFoo"; // Value not used
+ const std::string experiment_name = "SafeBrowsingAndroid";
+ ASSERT_TRUE(
+ base::FieldTrialList::CreateFieldTrial(experiment_name, group_name));
+
+ std::map<std::string, std::string> params;
+ if (!types_to_check_val.empty())
+ params["types_to_check"] = types_to_check_val;
+
+ ASSERT_TRUE(variations::AssociateVariationParams(experiment_name,
+ group_name, params));
+ }
+
+ scoped_ptr<base::FieldTrialList> field_trials_;
+ TestSafeBrowsingApiHandler api_handler_;
+ scoped_refptr<RemoteSafeBrowsingDatabaseManager> db_;
+};
+
+TEST_F(RemoteDatabaseManagerTest, DisabledViaNull) {
+ EXPECT_TRUE(db_->IsSupported());
+
+ SafeBrowsingApiHandler::SetInstance(nullptr);
+ EXPECT_FALSE(db_->IsSupported());
+}
+
+TEST_F(RemoteDatabaseManagerTest, TypesToCheckDefault) {
+ // Most are true, a few are false.
+ for (int t_int = 0; t_int < content::RESOURCE_TYPE_LAST_TYPE; t_int++) {
+ content::ResourceType t = static_cast<content::ResourceType>(t_int);
+ switch (t) {
+ case content::RESOURCE_TYPE_STYLESHEET:
+ case content::RESOURCE_TYPE_IMAGE:
+ case content::RESOURCE_TYPE_FONT_RESOURCE:
+ case content::RESOURCE_TYPE_FAVICON:
+ EXPECT_FALSE(db_->CanCheckResourceType(t));
+ break;
+ default:
+ EXPECT_TRUE(db_->CanCheckResourceType(t));
+ break;
+ }
+ }
+}
+
+TEST_F(RemoteDatabaseManagerTest, TypesToCheckFromTrial) {
+ SetFieldTrialParams("1,2,blah, 9");
+ db_ = new RemoteSafeBrowsingDatabaseManager();
+ EXPECT_TRUE(db_->CanCheckResourceType(
+ content::RESOURCE_TYPE_MAIN_FRAME)); // defaulted
+ EXPECT_TRUE(db_->CanCheckResourceType(content::RESOURCE_TYPE_SUB_FRAME));
+ EXPECT_TRUE(db_->CanCheckResourceType(content::RESOURCE_TYPE_STYLESHEET));
+ EXPECT_FALSE(db_->CanCheckResourceType(content::RESOURCE_TYPE_SCRIPT));
+ EXPECT_FALSE(db_->CanCheckResourceType(content::RESOURCE_TYPE_IMAGE));
+ // ...
+ EXPECT_FALSE(db_->CanCheckResourceType(content::RESOURCE_TYPE_MEDIA));
+ EXPECT_TRUE(db_->CanCheckResourceType(content::RESOURCE_TYPE_WORKER));
+}
+
+} // namespace safe_browsing
« no previous file with comments | « chrome/browser/safe_browsing/remote_database_manager.cc ('k') | chrome/browser/safe_browsing/safe_browsing_api_handler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698