Parser recursion check

Parser recursion check

Let the parser issue a compile-time error when the C stack is about to overflow, instead of crashing the VM.

BUG=24476
R=rmacnak@google.com

Committed: https://github.com/dart-lang/sdk/commit/783cc8acae0bb74387cf25c4550284ded23db351

[hausner, 2016-01-22 00:34:31]

Description was changed from

==========
Parser recursion check

Let parser issue a compile-time error when the C stack is about to overflow,
instead of crashing the VM.

BUG=24476
==========

to

==========
Parser recursion check

Let the parser issue a compile-time error when the C stack is about to overflow,
instead of crashing the VM.

BUG=24476
==========

[hausner, 2016-01-22 00:35:43]

hausner@google.com changed reviewers:
+ rmacnak@google.com

[rmacnak, 2016-01-22 00:45:28]

lgtm w/c

https://chromiumcodereview.appspot.com/1620493002/diff/1/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://chromiumcodereview.appspot.com/1620493002/diff/1/runtime/vm/parser.cc...
runtime/vm/parser.cc:6143: if ((c_stack_base > 0) && (c_stack_pos <
c_stack_limit)) {
Add comment that c_stack_base > 0 handles the case where we aren't initialized
yet.

[hausner, 2016-01-22 16:59:49]

Description was changed from

==========
Parser recursion check

Let the parser issue a compile-time error when the C stack is about to overflow,
instead of crashing the VM.

BUG=24476
==========

to

==========
Parser recursion check

Let the parser issue a compile-time error when the C stack is about to overflow,
instead of crashing the VM.

BUG=24476
R=rmacnak@google.com

Committed:
https://github.com/dart-lang/sdk/commit/783cc8acae0bb74387cf25c4550284ded23db351
==========

[hausner, 2016-01-22 16:59:50]

Committed patchset #2 (id:20001) manually as
783cc8acae0bb74387cf25c4550284ded23db351 (presubmit successful).

[hausner, 2016-01-22 18:38:14]

Thank you.

https://codereview.chromium.org/1620493002/diff/1/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/1620493002/diff/1/runtime/vm/parser.cc#newcod...
runtime/vm/parser.cc:6143: if ((c_stack_base > 0) && (c_stack_pos <
c_stack_limit)) {
On 2016/01/22 00:45:28, rmacnak wrote:
> Add comment that c_stack_base > 0 handles the case where we aren't initialized
> yet.

Done.