Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1620333002: Revert of Consolidate SK_CRASH and sk_throw into SK_ABORT (Closed)

Created:
4 years, 11 months ago by djsollen
Modified:
4 years, 11 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Consolidate SK_CRASH and sk_throw into SK_ABORT (patchset #5 id:80001 of https://codereview.chromium.org/1610823002/ ) Reason for revert: Chrome is calling SK_CRASH Original issue's description: > Consolidate SK_CRASH and sk_throw into SK_ABORT > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1610823002 > > Committed: https://skia.googlesource.com/skia/+/4c5cd7d527ed29aabfa72aa47b23a4496eeda357 TBR=reed@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/aa97a84404c7505738713a4c19b42347c7daef9e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -54 lines) Patch
M bench/ChecksumBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M bench/nanobench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/textblob.cpp View 1 chunk +1 line, -1 line 0 comments Download
M include/config/SkUserConfig.h View 1 chunk +7 lines, -0 lines 0 comments Download
M include/core/SkPostConfig.h View 2 chunks +35 lines, -14 lines 0 comments Download
M include/core/SkTArray.h View 1 chunk +1 line, -1 line 0 comments Download
M include/core/SkTypes.h View 3 chunks +3 lines, -7 lines 0 comments Download
M src/core/SkPath.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkRegionPriv.h View 1 chunk +1 line, -1 line 0 comments Download
M src/device/xps/SkXPSDevice.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M src/gpu/GrAllocator.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrTRecorder.h View 1 chunk +1 line, -1 line 0 comments Download
M src/pathops/SkPathOpsDebug.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ports/SkFontHost_win.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/ports/SkFontMgr_fontconfig.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/ports/SkFontMgr_win_dw.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/ports/SkMemory_malloc.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M src/ports/SkMemory_mozalloc.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M src/ports/SkTypeface_win_dw.h View 1 chunk +1 line, -1 line 0 comments Download
M src/ports/SkTypeface_win_dw.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/CachedDataTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/PathOpsCubicLineIntersectionIdeas.cpp View 5 chunks +11 lines, -11 lines 0 comments Download
M tools/Stats.h View 1 chunk +1 line, -1 line 0 comments Download
M tools/sk_tool_utils_font.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
djsollen
Created Revert of Consolidate SK_CRASH and sk_throw into SK_ABORT
4 years, 11 months ago (2016-01-22 14:50:05 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1620333002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1620333002/1
4 years, 11 months ago (2016-01-22 14:50:13 UTC) #2
commit-bot: I haz the power
4 years, 11 months ago (2016-01-22 14:50:28 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/aa97a84404c7505738713a4c19b42347c7daef9e

Powered by Google App Engine
This is Rietveld 408576698