Revert of Consolidate SK_CRASH and sk_throw into SK_ABORT

include/core/SkPostConfig.h

 /*
  * Copyright 2006 The Android Open Source Project
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 // IWYU pragma: private, include "SkTypes.h"
 
 #ifndef SkPostConfig_DEFINED
@@ skipping 85 matching lines @@
 #  else
 #    define SkNO_RETURN_HINT() do {} while (false)
 #  endif
 #endif
 
 ///////////////////////////////////////////////////////////////////////////////
 
 // TODO(mdempsky): Move elsewhere as appropriate.
 #include <new>
 
+#ifndef SK_CRASH
+#  ifdef SK_BUILD_FOR_WIN
+#    define SK_CRASH() __debugbreak()
+#  else
+#    if 1   // set to 0 for infinite loop, which can help connecting gdb
+#      define SK_CRASH() do { SkNO_RETURN_HINT(); *(int *)(uintptr_t)0xbbadbeef = 0; } while (false)
+#    else
+#      define SK_CRASH() do { SkNO_RETURN_HINT(); } while (true)
+#    endif
+#  endif
+#endif
 
 ///////////////////////////////////////////////////////////////////////////////
 
 #ifdef SK_BUILD_FOR_WIN
 #  ifndef WIN32_LEAN_AND_MEAN
 #    define WIN32_LEAN_AND_MEAN
 #    define WIN32_IS_MEAN_WAS_LOCALLY_DEFINED
 #  endif
 #  ifndef NOMINMAX
 #    define NOMINMAX
@@ skipping 14 matching lines @@
 #  ifndef SK_A32_SHIFT
 #    define SK_A32_SHIFT 24
 #    define SK_R32_SHIFT 16
 #    define SK_G32_SHIFT 8
 #    define SK_B32_SHIFT 0
 #  endif
 #
 #endif
 
 #if defined(GOOGLE3)
+    // Used as argument to DumpStackTrace in SK_ALWAYSBREAK.
     void SkDebugfForDumpStackTrace(const char* data, void* unused);
-    void DumpStackTrace(int skip_count, void w(const char*, void*), void* arg);
-#  define SK_DUMP_GOOGLE3_STACK() DumpStackTrace(0, SkDebugfForDumpStackTrace, nullptr)
-#else
-#  define SK_DUMP_GOOGLE3_STACK()
 #endif
 
-#ifndef SK_ABORT
-#  define SK_ABORT(msg) \
-    do { \
-       SkNO_RETURN_HINT(); \
-       SkDebugf("%s:%d: fatal error: \"%s\"\n", __FILE__, __LINE__, #msg); \
-       SK_DUMP_GOOGLE3_STACK(); \
-       sk_abort_no_print(); \
-    } while (false)
+#ifndef SK_ALWAYSBREAK
+#  if defined(GOOGLE3)
+     void DumpStackTrace(int skip_count, void w(const char*, void*),
+                         void* arg);
+#    define SK_ALWAYSBREAK(cond) do { \
+              if (cond) break; \
+              SkNO_RETURN_HINT(); \
+              SkDebugf("%s:%d: failed assertion \"%s\"\n", __FILE__, __LINE__, #cond); \
+              DumpStackTrace(0, SkDebugfForDumpStackTrace, nullptr); \
+              SK_CRASH(); \
+        } while (false)
+#  elif defined(SK_DEBUG)
+#    define SK_ALWAYSBREAK(cond) do { \
+              if (cond) break; \
+              SkNO_RETURN_HINT(); \
+              SkDebugf("%s:%d: failed assertion \"%s\"\n", __FILE__, __LINE__, #cond); \
+              SK_CRASH(); \
+        } while (false)
+#  else
+#    define SK_ALWAYSBREAK(cond) do { if (cond) break; SK_CRASH(); } while (false)
+#  endif
 #endif
 
 /**
  *  We check to see if the SHIFT value has already been defined.
  *  if not, we define it ourself to some default values. We default to OpenGL
  *  order (in memory: r,g,b,a)
  */
 #ifndef SK_A32_SHIFT
 #  ifdef SK_CPU_BENDIAN
 #    define SK_R32_SHIFT    24
@@ skipping 173 matching lines @@
 #  define SK_GAMMA_EXPONENT (2.2f)
 #endif
 
 //////////////////////////////////////////////////////////////////////
 
 #ifndef GR_TEST_UTILS
 #  define GR_TEST_UTILS 1
 #endif
 
 #endif // SkPostConfig_DEFINED