Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1620203004: Notification action icons prototype. (Closed)

Created:
4 years, 11 months ago by Michael van Ouwerkerk
Modified:
4 years, 9 months ago
Reviewers:
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Notification action icons prototype. This is a prototype, do not submit. BUG=581336

Patch Set 1 #

Patch Set 2 : Make it work on Android and clean up. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+549 lines, -263 lines) Patch
M chrome/android/java/res/layout/web_notification_button.xml View 1 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/notifications/CustomNotificationBuilder.java View 1 10 chunks +94 lines, -23 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationUIManager.java View 1 2 chunks +16 lines, -6 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/notifications/StandardNotificationBuilder.java View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/notifications/notification_ui_manager_android.cc View 1 3 chunks +12 lines, -7 lines 0 comments Download
M chrome/browser/notifications/platform_notification_service_impl.h View 1 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/notifications/platform_notification_service_impl.cc View 1 8 chunks +21 lines, -12 lines 0 comments Download
M chrome/browser/push_messaging/push_messaging_notification_manager.cc View 1 3 chunks +4 lines, -3 lines 0 comments Download
M content/browser/notifications/notification_message_filter.h View 1 4 chunks +7 lines, -6 lines 0 comments Download
M content/browser/notifications/notification_message_filter.cc View 1 5 chunks +12 lines, -12 lines 0 comments Download
M content/child/notifications/notification_data_conversions.cc View 1 2 chunks +3 lines, -0 lines 0 comments Download
M content/child/notifications/notification_image_loader.h View 1 4 chunks +5 lines, -4 lines 0 comments Download
M content/child/notifications/notification_image_loader.cc View 1 3 chunks +3 lines, -7 lines 0 comments Download
M content/child/notifications/notification_manager.h View 1 3 chunks +4 lines, -5 lines 0 comments Download
M content/child/notifications/notification_manager.cc View 1 11 chunks +45 lines, -21 lines 0 comments Download
A content/child/notifications/pending_notification.h View 1 1 chunk +76 lines, -0 lines 0 comments Download
A content/child/notifications/pending_notification.cc View 1 1 chunk +80 lines, -0 lines 0 comments Download
M content/child/notifications/pending_notifications_tracker.h View 1 3 chunks +26 lines, -51 lines 0 comments Download
M content/child/notifications/pending_notifications_tracker.cc View 1 2 chunks +26 lines, -70 lines 0 comments Download
M content/common/platform_notification_messages.h View 1 4 chunks +21 lines, -12 lines 0 comments Download
M content/content_child.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download
M content/content_common.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/public/browser/platform_notification_service.h View 1 4 chunks +7 lines, -6 lines 0 comments Download
A content/public/common/notification_resources.h View 1 1 chunk +27 lines, -0 lines 0 comments Download
M content/public/common/platform_notification_data.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/notifications/Notification.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/notifications/NotificationAction.idl View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/notifications/NotificationData.cpp View 1 chunk +9 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/notifications/NotificationOptions.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/public/platform/modules/notifications/WebNotificationAction.h View 1 chunk +2 lines, -10 lines 0 comments Download
M ui/gfx/android/java_bitmap.h View 1 2 chunks +8 lines, -0 lines 0 comments Download
M ui/gfx/android/java_bitmap.cc View 1 2 chunks +22 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (3 generated)
Michael van Ouwerkerk
Description was changed from ========== Add support for Notification action icons. BUG= ========== to ========== ...
4 years, 11 months ago (2016-01-26 12:50:20 UTC) #1
Michael van Ouwerkerk
Description was changed from ========== Add support for Notification action icons. This is a prototype, ...
4 years, 11 months ago (2016-01-26 14:26:32 UTC) #2
Michael van Ouwerkerk
4 years, 10 months ago (2016-02-01 10:30:08 UTC) #3 
Description was changed from

==========
Add support for Notification action icons.

This is a prototype, do not submit.

BUG=581336
==========

to

==========
Notification action icons prototype.

This is a prototype, do not submit.

BUG=581336
==========

Powered by Google App Engine
This is Rietveld 408576698