Fix best credentials selection algorithm in Password Manager.

Fix best credentials selection algorithm in Password Manager.

Currently we select best matches as credentials with highest store, independently of usernames. And so if there are credentials for different usernames stored on different forms (for example on Sign-In and Sign-Up forms) we propose to autofill only one credentials, since they have different score. This patch changed our selection algorithm by choosing the best credentials by each username separately.

Since these changes in logic, we might have mixed PSL-non PSL matches in |best_matches_| so both PSL and non PSL matches might be shown in a suggestion dropdown, but it was implemented not to show PSL matched credentials in manage bubble.

BUG=579485
Committed: https://crrev.com/f2bd438bf1d535308aa9041ec9cfe712303a999b
Cr-Commit-Position: refs/heads/master@{#371508}

[dvadym, 2016-01-26 13:09:09]

Description was changed from

==========
Fix password form scoring.

Not ready for review yet

BUG=579485
==========

to

==========
Fix best credentials selection algorithm in Password Manager.

Currently we select best matches as credentials with highest store,
independently of usernames. And so if there are credentials for different
usernames stored on different forms (for example on Sign-In and Sign-Up forms)
we propose to autofill only one credentials, since they have different score.
This patch changed our selection algorithm by choosing the best credentials by
each username separately.

BUG=579485
==========

[dvadym, 2016-01-26 13:14:26]

Description was changed from

==========
Fix best credentials selection algorithm in Password Manager.

Currently we select best matches as credentials with highest store,
independently of usernames. And so if there are credentials for different
usernames stored on different forms (for example on Sign-In and Sign-Up forms)
we propose to autofill only one credentials, since they have different score.
This patch changed our selection algorithm by choosing the best credentials by
each username separately.

BUG=579485
==========

to

==========
Fix best credentials selection algorithm in Password Manager.

Currently we select best matches as credentials with highest store,
independently of usernames. And so if there are credentials for different
usernames stored on different forms (for example on Sign-In and Sign-Up forms)
we propose to autofill only one credentials, since they have different score.
This patch changed our selection algorithm by choosing the best credentials by
each username separately.

Since these changes in logic, we might have mixed PSL-non PSL matches in
|best_matches_| so both PSL and non PSL matches might be shown in a suggestion
dropdown, but it was implemented not to show PSL matched credentials in manage
bubble.

BUG=579485
==========

[dvadym, 2016-01-26 13:15:45]

dvadym@chromium.org changed reviewers:
+ vabr@chromium.org

[dvadym, 2016-01-26 13:15:45]

Hi Vaclav,

 Could you please review this CL?

Best regards,
Vadym

[vabr (Chromium), 2016-01-26 13:45:07]

LGTM!
Cheers,
Vaclav

[dvadym, 2016-01-26 14:40:42]

The CQ bit was checked by dvadym@chromium.org

[commit-bot: I haz the power, 2016-01-26 14:40:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1620083003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1620083003/80001

[commit-bot: I haz the power, 2016-01-26 14:45:35]

Description was changed from

==========
Fix best credentials selection algorithm in Password Manager.

Currently we select best matches as credentials with highest store,
independently of usernames. And so if there are credentials for different
usernames stored on different forms (for example on Sign-In and Sign-Up forms)
we propose to autofill only one credentials, since they have different score.
This patch changed our selection algorithm by choosing the best credentials by
each username separately.

Since these changes in logic, we might have mixed PSL-non PSL matches in
|best_matches_| so both PSL and non PSL matches might be shown in a suggestion
dropdown, but it was implemented not to show PSL matched credentials in manage
bubble.

BUG=579485
==========

to

==========
Fix best credentials selection algorithm in Password Manager.

Currently we select best matches as credentials with highest store,
independently of usernames. And so if there are credentials for different
usernames stored on different forms (for example on Sign-In and Sign-Up forms)
we propose to autofill only one credentials, since they have different score.
This patch changed our selection algorithm by choosing the best credentials by
each username separately.

Since these changes in logic, we might have mixed PSL-non PSL matches in
|best_matches_| so both PSL and non PSL matches might be shown in a suggestion
dropdown, but it was implemented not to show PSL matched credentials in manage
bubble.

BUG=579485
==========

[commit-bot: I haz the power, 2016-01-26 14:45:37]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-01-26 14:46:25]

Description was changed from

==========
Fix best credentials selection algorithm in Password Manager.

Currently we select best matches as credentials with highest store,
independently of usernames. And so if there are credentials for different
usernames stored on different forms (for example on Sign-In and Sign-Up forms)
we propose to autofill only one credentials, since they have different score.
This patch changed our selection algorithm by choosing the best credentials by
each username separately.

Since these changes in logic, we might have mixed PSL-non PSL matches in
|best_matches_| so both PSL and non PSL matches might be shown in a suggestion
dropdown, but it was implemented not to show PSL matched credentials in manage
bubble.

BUG=579485
==========

to

==========
Fix best credentials selection algorithm in Password Manager.

Currently we select best matches as credentials with highest store,
independently of usernames. And so if there are credentials for different
usernames stored on different forms (for example on Sign-In and Sign-Up forms)
we propose to autofill only one credentials, since they have different score.
This patch changed our selection algorithm by choosing the best credentials by
each username separately.

Since these changes in logic, we might have mixed PSL-non PSL matches in
|best_matches_| so both PSL and non PSL matches might be shown in a suggestion
dropdown, but it was implemented not to show PSL matched credentials in manage
bubble.

BUG=579485

Committed: https://crrev.com/f2bd438bf1d535308aa9041ec9cfe712303a999b
Cr-Commit-Position: refs/heads/master@{#371508}
==========

[commit-bot: I haz the power, 2016-01-26 14:46:26]

Patchset 5 (id:??) landed as
https://crrev.com/f2bd438bf1d535308aa9041ec9cfe712303a999b
Cr-Commit-Position: refs/heads/master@{#371508}