Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3916)

Unified Diff: chrome/browser/ui/views/passwords/manage_password_items_view.cc

Issue 1620083003: Fix best credentials selection algorithm in Password Manager. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Tests added Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/passwords/manage_password_items_view.cc
diff --git a/chrome/browser/ui/views/passwords/manage_password_items_view.cc b/chrome/browser/ui/views/passwords/manage_password_items_view.cc
index cd35ea508064acdb4d856ee2cf643369b9f95f9d..b509ea2f48c2e998a80aa1cd8efe07f12a6153e9 100644
--- a/chrome/browser/ui/views/passwords/manage_password_items_view.cc
+++ b/chrome/browser/ui/views/passwords/manage_password_items_view.cc
@@ -267,8 +267,9 @@ ManagePasswordItemsView::ManagePasswordItemsView(
: model_(manage_passwords_bubble_model) {
int fixed_height = PasswordFormRow::GetFixedHeight(model_->state());
for (const autofill::PasswordForm* password_form : password_forms) {
- password_forms_rows_.push_back(
- new PasswordFormRow(this, password_form, fixed_height));
+ if (!password_form->is_public_suffix_match)
+ password_forms_rows_.push_back(
+ new PasswordFormRow(this, password_form, fixed_height));
}
AddRows();
}

Powered by Google App Engine
This is Rietveld 408576698