Run recursive file operations sequentially.

Run recursive file operations sequentially.

Parallel copy can have huge performance drop in some cases. (See issue 578923 for the detail)
For safety and simplicity, this CL makes the recursive file operations sequential.

BUG=578923
TEST=manually confirm the performance of copying a directory to a SD card.

Committed: https://crrev.com/141a612f9d12ff9e5194dbba6d81d9d812f8ea7d
Cr-Commit-Position: refs/heads/master@{#371467}

[fukino, 2016-01-22 06:40:11]

Description was changed from

==========
Run recursive file operations sequentially.

BUG=578923
TEST=manually confirm the performance on copy a directory.
==========

to

==========
Run recursive file operations sequentially.

Parallel copy can have huge performance drop in some cases. (See issue 578923
for the detail)
For safety and simplicity, this CL makes the recursive file operations
sequential.

BUG=578923
TEST=manually confirm the performance on copy a directory.
==========

[fukino, 2016-01-22 06:40:56]

Description was changed from

==========
Run recursive file operations sequentially.

Parallel copy can have huge performance drop in some cases. (See issue 578923
for the detail)
For safety and simplicity, this CL makes the recursive file operations
sequential.

BUG=578923
TEST=manually confirm the performance on copy a directory.
==========

to

==========
Run recursive file operations sequentially.

Parallel copy can have huge performance drop in some cases. (See issue 578923
for the detail)
For safety and simplicity, this CL makes the recursive file operations
sequential.

BUG=578923
TEST=manually confirm the performance of copying a directory to a SD card.
==========

[fukino, 2016-01-22 06:43:29]

fukino@chromium.org changed reviewers:
+ tzik@chromium.org

[fukino, 2016-01-22 06:43:29]

Hi tzik@, could you take a look?

https://codereview.chromium.org/1619733004/diff/1/storage/browser/fileapi/rec...
File storage/browser/fileapi/recursive_operation_delegate.cc (left):

https://codereview.chromium.org/1619733004/diff/1/storage/browser/fileapi/rec...
storage/browser/fileapi/recursive_operation_delegate.cc:154: if
((pending_files_.empty() || canceled_) && inflight_operations_ == 0) {
I think this check for inflight_operations_ can simply be removed.
No matter how this ProcessPendingFiles called (in DidReadDirectory or
DidProcessFile), there is no in-flight ProcessFile task.

[fukino, 2016-01-22 07:31:04]

Oops, I'll fix a unit test.

[tzik, 2016-01-25 00:27:35]

lgtm

[fukino, 2016-01-26 02:11:48]

On 2016/01/25 00:27:35, tzik wrote:
> lgtm

Thank you!

[fukino, 2016-01-26 02:11:49]

On 2016/01/25 00:27:35, tzik wrote:
> lgtm

Thank you!

[fukino, 2016-01-26 04:45:35]

The CQ bit was checked by fukino@chromium.org

[commit-bot: I haz the power, 2016-01-26 04:46:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1619733004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1619733004/20001

[commit-bot: I haz the power, 2016-01-26 06:14:55]

Description was changed from

==========
Run recursive file operations sequentially.

Parallel copy can have huge performance drop in some cases. (See issue 578923
for the detail)
For safety and simplicity, this CL makes the recursive file operations
sequential.

BUG=578923
TEST=manually confirm the performance of copying a directory to a SD card.
==========

to

==========
Run recursive file operations sequentially.

Parallel copy can have huge performance drop in some cases. (See issue 578923
for the detail)
For safety and simplicity, this CL makes the recursive file operations
sequential.

BUG=578923
TEST=manually confirm the performance of copying a directory to a SD card.
==========

[commit-bot: I haz the power, 2016-01-26 06:14:56]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-01-26 06:16:02]

Description was changed from

==========
Run recursive file operations sequentially.

Parallel copy can have huge performance drop in some cases. (See issue 578923
for the detail)
For safety and simplicity, this CL makes the recursive file operations
sequential.

BUG=578923
TEST=manually confirm the performance of copying a directory to a SD card.
==========

to

==========
Run recursive file operations sequentially.

Parallel copy can have huge performance drop in some cases. (See issue 578923
for the detail)
For safety and simplicity, this CL makes the recursive file operations
sequential.

BUG=578923
TEST=manually confirm the performance of copying a directory to a SD card.

Committed: https://crrev.com/141a612f9d12ff9e5194dbba6d81d9d812f8ea7d
Cr-Commit-Position: refs/heads/master@{#371467}
==========

[commit-bot: I haz the power, 2016-01-26 06:16:02]

Patchset 2 (id:??) landed as
https://crrev.com/141a612f9d12ff9e5194dbba6d81d9d812f8ea7d
Cr-Commit-Position: refs/heads/master@{#371467}