Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Unified Diff: content/browser/fileapi/copy_or_move_operation_delegate_unittest.cc

Issue 1619733004: Run recursive file operations sequentially. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix a unit test which assumed parallel copy. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | storage/browser/fileapi/recursive_operation_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/fileapi/copy_or_move_operation_delegate_unittest.cc
diff --git a/content/browser/fileapi/copy_or_move_operation_delegate_unittest.cc b/content/browser/fileapi/copy_or_move_operation_delegate_unittest.cc
index 055b8f2c97f7e96201205f9049cf280cd6dac9cb..6e2fcca758c9b74bccd9e81c3d6be5ff02a40f44 100644
--- a/content/browser/fileapi/copy_or_move_operation_delegate_unittest.cc
+++ b/content/browser/fileapi/copy_or_move_operation_delegate_unittest.cc
@@ -619,8 +619,10 @@ TEST(LocalFileSystemCopyOrMoveOperationTest,
ASSERT_TRUE(helper.DirectoryExists(src));
ASSERT_TRUE(helper.DirectoryExists(dest));
+ // In the move operation, [file 0, file 2, file 3] are processed as LIFO.
+ // After file 3 is processed, file 2 is rejected by the validator and the
+ // operation fails. That is, only file 3 should be in dest.
FileSystemTestCaseRecord kMoveDirResultCases[] = {
- {false, FILE_PATH_LITERAL("file 0"), 38},
{false, FILE_PATH_LITERAL("file 3"), 0},
};
« no previous file with comments | « no previous file | storage/browser/fileapi/recursive_operation_delegate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698