Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(856)

Unified Diff: third_party/WebKit/Source/modules/notifications/Notification.h

Issue 1619703002: Implement notificationclose event (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/notifications/Notification.h
diff --git a/third_party/WebKit/Source/modules/notifications/Notification.h b/third_party/WebKit/Source/modules/notifications/Notification.h
index 3ecfcf118f2a1472aeb2b63772df3b7dba4b580d..4ba4e474139d72066bed188c4d0e7a0d2fe2fa4d 100644
--- a/third_party/WebKit/Source/modules/notifications/Notification.h
+++ b/third_party/WebKit/Source/modules/notifications/Notification.h
@@ -65,8 +65,9 @@ public:
// the notification to be displayed to the user when the developer-provided data is valid.
static Notification* create(ExecutionContext*, const String& title, const NotificationOptions&, ExceptionState&);
- // Used for embedder-created Notification objects. Will initialize the Notification's state as showing.
- static Notification* create(ExecutionContext*, int64_t persistentId, const WebNotificationData&);
+ // Used for embedder-created Notification objects. If |showing| is true, will initialize the
+ // Notification's state as showing, or as closing otherwise.
Peter Beverloo 2016/01/26 16:13:45 closing? I think we should initialize it as Notifi
Nina 2016/01/27 18:48:58 Makes sense. Fixed.
+ static Notification* create(ExecutionContext*, int64_t persistentId, const WebNotificationData&, bool showing);
~Notification() override;

Powered by Google App Engine
This is Rietveld 408576698