third_party/WebKit/Source/modules/notifications/Notification.cpp - Issue 1619703002: Implement notificationclose event

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/notifications/Notification.cpp

Issue 1619703002: Implement notificationclose event (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/notifications/Notification.cpp

diff --git a/third_party/WebKit/Source/modules/notifications/Notification.cpp b/third_party/WebKit/Source/modules/notifications/Notification.cpp

index 00801a281c23bbe7999da1cdf14e399a025ebd59..1ef281c97cd6caff31e6ba0e4542ea4b04456ece 100644

--- a/third_party/WebKit/Source/modules/notifications/Notification.cpp

+++ b/third_party/WebKit/Source/modules/notifications/Notification.cpp

@@ -101,11 +101,11 @@ Notification* Notification::create(ExecutionContext* context, const String& titl

return notification;

}

-Notification* Notification::create(ExecutionContext* context, int64_t persistentId, const WebNotificationData& data)

+Notification* Notification::create(ExecutionContext* context, int64_t persistentId, const WebNotificationData& data, bool showing)

{

Notification* notification = new Notification(context, data);

notification->setPersistentId(persistentId);

- notification->setState(NotificationStateShowing);

+ notification->setState(showing ? NotificationStateShowing : NotificationStateClosing);

notification->suspendIfNeeded();

return notification;