Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(786)

Unified Diff: content/browser/service_worker/service_worker_version.h

Issue 1619703002: Implement notificationclose event (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_version.h
diff --git a/content/browser/service_worker/service_worker_version.h b/content/browser/service_worker/service_worker_version.h
index f8619b77efc6df230e3cd51c3b55c1a823052657..36238acf220f0257c33c7d23a9d9c682a2834b77 100644
--- a/content/browser/service_worker/service_worker_version.h
+++ b/content/browser/service_worker/service_worker_version.h
@@ -273,6 +273,16 @@ class CONTENT_EXPORT ServiceWorkerVersion
const PlatformNotificationData& notification_data,
int action_index);
+ // Sends notificationclose event to the associated embedded worker and
+ // asynchronously calls |callback| when it errors out or it gets a response
+ // from the worker to notify completion.
+ //
+ // This must be called when the status() is ACTIVATED.
+ void DispatchNotificationCloseEvent(
+ const StatusCallback& callback,
+ int64_t persistent_notification_id,
+ const PlatformNotificationData& notification_data);
+
// Sends push event to the associated embedded worker and asynchronously calls
// |callback| when it errors out or it gets a response from the worker to
// notify completion.
@@ -409,6 +419,7 @@ class CONTENT_EXPORT ServiceWorkerVersion
REQUEST_INSTALL,
REQUEST_FETCH,
REQUEST_NOTIFICATION_CLICK,
+ REQUEST_NOTIFICATION_CLOSE,
REQUEST_PUSH,
REQUEST_CUSTOM,
NUM_REQUEST_TYPES
@@ -574,6 +585,7 @@ class CONTENT_EXPORT ServiceWorkerVersion
void OnPushEventFinished(int request_id,
blink::WebServiceWorkerEventResult result);
void OnOpenWindow(int request_id, GURL url);
+ void OnNotificationCloseEventFinished(int request_id);
void OnOpenWindowFinished(int request_id,
ServiceWorkerStatusCode status,
const std::string& client_uuid,
@@ -701,6 +713,8 @@ class CONTENT_EXPORT ServiceWorkerVersion
IDMap<PendingRequest<FetchCallback>, IDMapOwnPointer> fetch_requests_;
IDMap<PendingRequest<StatusCallback>, IDMapOwnPointer>
notification_click_requests_;
+ IDMap<PendingRequest<StatusCallback>, IDMapOwnPointer>
+ notification_close_requests_;
IDMap<PendingRequest<StatusCallback>, IDMapOwnPointer> push_requests_;
IDMap<PendingRequest<StatusCallback>, IDMapOwnPointer> custom_requests_;

Powered by Google App Engine
This is Rietveld 408576698