content/browser/service_worker/service_worker_metrics.cc - Issue 1619703002: Implement notificationclose event

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_metrics.cc

Issue 1619703002: Implement notificationclose event (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/service_worker/service_worker_metrics.cc

diff --git a/content/browser/service_worker/service_worker_metrics.cc b/content/browser/service_worker/service_worker_metrics.cc

index 64c8d4325b58e5483b8b3e63b48433bde7fdabfe..fb495ae69486ee2f702ca8ffdda2c10b4d7df468 100644

--- a/content/browser/service_worker/service_worker_metrics.cc

+++ b/content/browser/service_worker/service_worker_metrics.cc

@@ -207,6 +207,8 @@ void ServiceWorkerMetrics::RecordEventDuration(EventType event,

case EventType::FETCH:

// For now event duration for these events is not recorded.

case EventType::GEOFENCING:

+ // TODO(nsatragno): create UMA metric.

+ case EventType::NOTIFICATION_CLOSE:

case EventType::SERVICE_PORT_CONNECT:

case EventType::MESSAGE:

break;