Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1548)

Unified Diff: content/browser/service_worker/service_worker_metrics.cc

Issue 1619703002: Implement notificationclose event (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Recovered a lost piece of logging. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_metrics.cc
diff --git a/content/browser/service_worker/service_worker_metrics.cc b/content/browser/service_worker/service_worker_metrics.cc
index f32a0916099756054dcdcf6bb0973e3eee108550..5bfdf96ec8bebcdc9407ee3345a1a3a07273c0cc 100644
--- a/content/browser/service_worker/service_worker_metrics.cc
+++ b/content/browser/service_worker/service_worker_metrics.cc
@@ -58,6 +58,8 @@ const char* ServiceWorkerMetrics::EventTypeToString(EventType event_type) {
return "Sync";
case EventType::NOTIFICATION_CLICK:
return "Notification Click";
+ case EventType::NOTIFICATION_CLOSE:
+ return "Notification Close";
case EventType::PUSH:
return "Push";
case EventType::GEOFENCING:
@@ -234,6 +236,8 @@ void ServiceWorkerMetrics::RecordEventDuration(EventType event,
case EventType::FETCH:
// For now event duration for these events is not recorded.
case EventType::GEOFENCING:
+ // TODO(nsatragno): create UMA metric.
Peter Beverloo 2016/01/27 19:03:58 dito re: UMA
Nina 2016/01/28 11:59:01 Done.
+ case EventType::NOTIFICATION_CLOSE:
case EventType::SERVICE_PORT_CONNECT:
case EventType::MESSAGE:
break;

Powered by Google App Engine
This is Rietveld 408576698