Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(634)

Side by Side Diff: content/browser/service_worker/service_worker_metrics.cc

Issue 1619703002: Implement notificationclose event (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Recovered a lost piece of logging. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/service_worker/service_worker_metrics.h" 5 #include "content/browser/service_worker/service_worker_metrics.h"
6 6
7 #include "base/metrics/histogram_macros.h" 7 #include "base/metrics/histogram_macros.h"
8 #include "base/metrics/sparse_histogram.h" 8 #include "base/metrics/sparse_histogram.h"
9 #include "base/strings/string_util.h" 9 #include "base/strings/string_util.h"
10 #include "content/common/service_worker/service_worker_types.h" 10 #include "content/common/service_worker/service_worker_types.h"
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
51 case EventType::ACTIVATE: 51 case EventType::ACTIVATE:
52 return "Activate"; 52 return "Activate";
53 case EventType::INSTALL: 53 case EventType::INSTALL:
54 return "Install"; 54 return "Install";
55 case EventType::FETCH: 55 case EventType::FETCH:
56 return "Fetch"; 56 return "Fetch";
57 case EventType::SYNC: 57 case EventType::SYNC:
58 return "Sync"; 58 return "Sync";
59 case EventType::NOTIFICATION_CLICK: 59 case EventType::NOTIFICATION_CLICK:
60 return "Notification Click"; 60 return "Notification Click";
61 case EventType::NOTIFICATION_CLOSE:
62 return "Notification Close";
61 case EventType::PUSH: 63 case EventType::PUSH:
62 return "Push"; 64 return "Push";
63 case EventType::GEOFENCING: 65 case EventType::GEOFENCING:
64 return "Geofencing"; 66 return "Geofencing";
65 case EventType::SERVICE_PORT_CONNECT: 67 case EventType::SERVICE_PORT_CONNECT:
66 return "Service Port Connect"; 68 return "Service Port Connect";
67 case EventType::MESSAGE: 69 case EventType::MESSAGE:
68 return "Message"; 70 return "Message";
69 case EventType::NUM_TYPES: 71 case EventType::NUM_TYPES:
70 break; 72 break;
(...skipping 156 matching lines...) Expand 10 before | Expand all | Expand 10 after
227 time); 229 time);
228 break; 230 break;
229 case EventType::PUSH: 231 case EventType::PUSH:
230 UMA_HISTOGRAM_MEDIUM_TIMES("ServiceWorker.PushEvent.Time", time); 232 UMA_HISTOGRAM_MEDIUM_TIMES("ServiceWorker.PushEvent.Time", time);
231 break; 233 break;
232 234
233 // Event duration for fetch is recorded separately. 235 // Event duration for fetch is recorded separately.
234 case EventType::FETCH: 236 case EventType::FETCH:
235 // For now event duration for these events is not recorded. 237 // For now event duration for these events is not recorded.
236 case EventType::GEOFENCING: 238 case EventType::GEOFENCING:
239 // TODO(nsatragno): create UMA metric.
Peter Beverloo 2016/01/27 19:03:58 dito re: UMA
Nina 2016/01/28 11:59:01 Done.
240 case EventType::NOTIFICATION_CLOSE:
237 case EventType::SERVICE_PORT_CONNECT: 241 case EventType::SERVICE_PORT_CONNECT:
238 case EventType::MESSAGE: 242 case EventType::MESSAGE:
239 break; 243 break;
240 244
241 case EventType::NUM_TYPES: 245 case EventType::NUM_TYPES:
242 NOTREACHED() << "Invalid event type"; 246 NOTREACHED() << "Invalid event type";
243 break; 247 break;
244 } 248 }
245 } 249 }
246 250
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
303 UMA_HISTOGRAM_ENUMERATION("ServiceWorker.URLRequestJob.FallbackedRequestMode", 307 UMA_HISTOGRAM_ENUMERATION("ServiceWorker.URLRequestJob.FallbackedRequestMode",
304 mode, FETCH_REQUEST_MODE_LAST + 1); 308 mode, FETCH_REQUEST_MODE_LAST + 1);
305 } 309 }
306 310
307 void ServiceWorkerMetrics::RecordTimeBetweenEvents( 311 void ServiceWorkerMetrics::RecordTimeBetweenEvents(
308 const base::TimeDelta& time) { 312 const base::TimeDelta& time) {
309 UMA_HISTOGRAM_MEDIUM_TIMES("ServiceWorker.TimeBetweenEvents", time); 313 UMA_HISTOGRAM_MEDIUM_TIMES("ServiceWorker.TimeBetweenEvents", time);
310 } 314 }
311 315
312 } // namespace content 316 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698