Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Issue 1619663004: [Media Router] Remove second dialog state check in Dialog_Basic integration test on Linux. (Closed)

Created:
4 years, 11 months ago by apacible
Modified:
4 years, 11 months ago
Reviewers:
Lei Lei
CC:
chromium-reviews, media-router+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Media Router] Remove second dialog state check in Dialog_Basic integration test on Linux. BUG=577943 Committed: https://crrev.com/67979c2e029e2599433a2ec37d85eee114f44d97 Cr-Commit-Position: refs/heads/master@{#370793}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome/test/media_router/media_router_integration_ui_browsertest.cc View 2 chunks +4 lines, -0 lines 2 comments Download

Messages

Total messages: 15 (7 generated)
apacible
PTAL, thanks!
4 years, 11 months ago (2016-01-21 19:06:17 UTC) #3
Lei Lei
lgtm https://codereview.chromium.org/1619663004/diff/1/chrome/test/media_router/media_router_integration_ui_browsertest.cc File chrome/test/media_router/media_router_integration_ui_browsertest.cc (right): https://codereview.chromium.org/1619663004/diff/1/chrome/test/media_router/media_router_integration_ui_browsertest.cc#newcode98 chrome/test/media_router/media_router_integration_ui_browsertest.cc:98: WaitUntilDialogClosed(web_contents); I think we should keep this for ...
4 years, 11 months ago (2016-01-21 19:07:55 UTC) #4
apacible
https://codereview.chromium.org/1619663004/diff/1/chrome/test/media_router/media_router_integration_ui_browsertest.cc File chrome/test/media_router/media_router_integration_ui_browsertest.cc (right): https://codereview.chromium.org/1619663004/diff/1/chrome/test/media_router/media_router_integration_ui_browsertest.cc#newcode98 chrome/test/media_router/media_router_integration_ui_browsertest.cc:98: WaitUntilDialogClosed(web_contents); On 2016/01/21 19:07:55, Lei Lei wrote: > I ...
4 years, 11 months ago (2016-01-21 19:10:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1619663004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1619663004/1
4 years, 11 months ago (2016-01-21 19:14:21 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/155531) linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, ...
4 years, 11 months ago (2016-01-21 20:15:35 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1619663004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1619663004/1
4 years, 11 months ago (2016-01-21 20:30:47 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-21 21:39:31 UTC) #13
commit-bot: I haz the power
4 years, 11 months ago (2016-01-21 21:40:30 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/67979c2e029e2599433a2ec37d85eee114f44d97
Cr-Commit-Position: refs/heads/master@{#370793}

Powered by Google App Engine
This is Rietveld 408576698