|
|
Description[Media Router] Remove second dialog state check in Dialog_Basic integration test on Linux.
BUG=577943
Committed: https://crrev.com/67979c2e029e2599433a2ec37d85eee114f44d97
Cr-Commit-Position: refs/heads/master@{#370793}
Patch Set 1 #
Total comments: 2
Messages
Total messages: 15 (7 generated)
Description was changed from ========== fix integration test BUG= ========== to ========== [Media Router] Remove second dialog state check in Dialog_Basic integration test on Linux. BUG=577943 ==========
apacible@chromium.org changed reviewers: + leilei@chromium.org
PTAL, thanks!
lgtm https://codereview.chromium.org/1619663004/diff/1/chrome/test/media_router/me... File chrome/test/media_router/media_router_integration_ui_browsertest.cc (right): https://codereview.chromium.org/1619663004/diff/1/chrome/test/media_router/me... chrome/test/media_router/media_router_integration_ui_browsertest.cc:98: WaitUntilDialogClosed(web_contents); I think we should keep this for Linux, because the dialog will be closed automatically if there is no user action after 3s, is it?
https://codereview.chromium.org/1619663004/diff/1/chrome/test/media_router/me... File chrome/test/media_router/media_router_integration_ui_browsertest.cc (right): https://codereview.chromium.org/1619663004/diff/1/chrome/test/media_router/me... chrome/test/media_router/media_router_integration_ui_browsertest.cc:98: WaitUntilDialogClosed(web_contents); On 2016/01/21 19:07:55, Lei Lei wrote: > I think we should keep this for Linux, because the dialog will be closed > automatically if there is no user action after 3s, is it? I removed this for Linux since it appears mouseenter/mouseleave event dispatching (not explicitly called by us) isn't consistent and so this could turn the test flaky.
The CQ bit was checked by apacible@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1619663004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1619663004/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by apacible@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1619663004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1619663004/1
Message was sent while issue was closed.
Description was changed from ========== [Media Router] Remove second dialog state check in Dialog_Basic integration test on Linux. BUG=577943 ========== to ========== [Media Router] Remove second dialog state check in Dialog_Basic integration test on Linux. BUG=577943 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== [Media Router] Remove second dialog state check in Dialog_Basic integration test on Linux. BUG=577943 ========== to ========== [Media Router] Remove second dialog state check in Dialog_Basic integration test on Linux. BUG=577943 Committed: https://crrev.com/67979c2e029e2599433a2ec37d85eee114f44d97 Cr-Commit-Position: refs/heads/master@{#370793} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/67979c2e029e2599433a2ec37d85eee114f44d97 Cr-Commit-Position: refs/heads/master@{#370793} |