[Media Router] Remove second dialog state check in Dialog_Basic integration test on Linux.

chrome/test/media_router/media_router_integration_ui_browsertest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/test/media_router/media_router_integration_browsertest.h"
 
 #include "base/files/file_util.h"
 #include "base/strings/stringprintf.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
 #include "chrome/grit/generated_resources.h"
@@ skipping 63 matching lines @@
 
   std::string sink_name_script = base::StringPrintf(
       "domAutomationController.send("
       "window.document.getElementById('media-router-container').shadowRoot."
       "getElementById('container-header').shadowRoot.getElementById("
       "'header-text').innerText)");
   std::string sink_name = ExecuteScriptAndExtractString(
       dialog_contents, sink_name_script);
   ASSERT_EQ(kTestSinkName, sink_name);
 
+#if defined(OS_MACOSX) || defined(OS_WIN)
   // Simulate moving the mouse off the dialog. Confirm that the dialog closes
   // automatically after the route is closed.
   // In tests, it sometimes takes too long to CloseRouteOnUI() to finish so
   // the timer started when the route is initially closed times out before the
   // mouseleave event is dispatched. In that case, the dialog remains open.
   std::string mouse_leave_script = base::StringPrintf(
       "domAutomationController.send("
       "window.document.getElementById('media-router-container').dispatchEvent("
       "new Event('mouseleave')))");
   ASSERT_TRUE(content::ExecuteScript(dialog_contents, mouse_leave_script));
+#endif
   CloseRouteOnUI();
+#if defined(OS_MACOSX) || defined(OS_WIN)
   WaitUntilDialogClosed(web_contents);

[Lei Lei, 2016/01/21 19:07:55]

I think we should keep this for Linux, because the dialog will be closed
automatically if there is no user action after 3s, is it?

[apacible, 2016/01/21 19:10:02]

I removed this for Linux since it appears mouseenter/mouseleave event
dispatching (not explicitly called by us) isn't consistent and so this could
turn the test flaky.

+#endif
 }
 
 IN_PROC_BROWSER_TEST_F(MediaRouterIntegrationBrowserTest,
                        MANUAL_Dialog_RouteCreationTimedOut) {
   SetTestData(FILE_PATH_LITERAL("route_creation_timed_out.json"));
   OpenTestPage(FILE_PATH_LITERAL("basic_test.html"));
   content::WebContents* web_contents =
       browser()->tab_strip_model()->GetActiveWebContents();
   content::WebContents* dialog_contents = OpenMRDialog(web_contents);
 
@@ skipping 19 matching lines @@
   std::string issue_title = GetIssueTitle();
   ASSERT_EQ(l10n_util::GetStringUTF8(
                 IDS_MEDIA_ROUTER_ISSUE_CREATE_ROUTE_TIMEOUT_FOR_TAB),
             issue_title);
 
   // Route will still get created, it just takes longer than usual.
   WaitUntilRouteCreated();
 }
 
 }  // namespace media_router