Revert "Fix deprecatation warning when building for recent SDKs on iOS/OS X."

Revert "Fix deprecatation warning when building for recent SDKs on iOS/OS X."

This reverts CL https://codereview.chromium.org/1563223004/
This reverts commit 7cc0d8562bf8b20b88cc941ba72593cb7230ecf6.

CL 1563223004 introduces two bugs on iOS.
- Encoding the minidump name with extra percent causing crash server to fail
  processing the file.
- Using a released pointer causing random crashes on upload. The
  data, resp, err pointers returned in the NSURLSession completion
  handler is released at the end of the block. When used later (to get
  the crash ID), it causes a crash.

BUG=569158
R=blundell@chromium.org, mark@chromium.org

Committed: https://chromium.googlesource.com/breakpad/breakpad/+/7da8acc8d4f2f950ae8d80d40614bb5bd3c6cf1d

[Olivier, 2016-01-21 09:26:57]

olivierrobin@chromium.org changed reviewers:
+ blundell@chromium.org, mark@chromium.org, rohitrao@chromium.org,
sdefresne@chromium.org

[blundell, 2016-01-21 09:27:53]

LGTM

Be a little more specific on what the released pointer is that's being used :)

[Olivier, 2016-01-21 09:30:26]

Description was changed from

==========
Revert "Fix deprecatation warning when building for recent SDKs on iOS/OS X."

This reverts CL https://codereview.chromium.org/1563223004/
This reverts commit 7cc0d8562bf8b20b88cc941ba72593cb7230ecf6.

CL 1563223004 introduces two bugs on iOS.
- Encoding the minidump name with extra percent causing crash server to fail
  processing the file.
- Using a released pointer causing random crashes on upload.

BUG=569158
==========

to

==========
Revert "Fix deprecatation warning when building for recent SDKs on iOS/OS X."

This reverts CL https://codereview.chromium.org/1563223004/
This reverts commit 7cc0d8562bf8b20b88cc941ba72593cb7230ecf6.

CL 1563223004 introduces two bugs on iOS.
- Encoding the minidump name with extra percent causing crash server to fail
  processing the file.
- Using a released pointer causing random crashes on upload. The
  data pointer returned in the NSURLSession completion handler is
  released at the end of the block. When used later (to get the crash
  ID), it cause a crash.

BUG=569158
==========

[Olivier, 2016-01-21 09:32:39]

Description was changed from

==========
Revert "Fix deprecatation warning when building for recent SDKs on iOS/OS X."

This reverts CL https://codereview.chromium.org/1563223004/
This reverts commit 7cc0d8562bf8b20b88cc941ba72593cb7230ecf6.

CL 1563223004 introduces two bugs on iOS.
- Encoding the minidump name with extra percent causing crash server to fail
  processing the file.
- Using a released pointer causing random crashes on upload. The
  data pointer returned in the NSURLSession completion handler is
  released at the end of the block. When used later (to get the crash
  ID), it cause a crash.

BUG=569158
==========

to

==========
Revert "Fix deprecatation warning when building for recent SDKs on iOS/OS X."

This reverts CL https://codereview.chromium.org/1563223004/
This reverts commit 7cc0d8562bf8b20b88cc941ba72593cb7230ecf6.

CL 1563223004 introduces two bugs on iOS.
- Encoding the minidump name with extra percent causing crash server to fail
  processing the file.
- Using a released pointer causing random crashes on upload. The
  data, resp, err pointers returned in the NSURLSession completion 
  handler is released at the end of the block. When used later (to get
  the crash ID), it cause a crash.

BUG=569158
==========

[Olivier, 2016-01-21 09:32:57]

Description was changed from

==========
Revert "Fix deprecatation warning when building for recent SDKs on iOS/OS X."

This reverts CL https://codereview.chromium.org/1563223004/
This reverts commit 7cc0d8562bf8b20b88cc941ba72593cb7230ecf6.

CL 1563223004 introduces two bugs on iOS.
- Encoding the minidump name with extra percent causing crash server to fail
  processing the file.
- Using a released pointer causing random crashes on upload. The
  data, resp, err pointers returned in the NSURLSession completion 
  handler is released at the end of the block. When used later (to get
  the crash ID), it cause a crash.

BUG=569158
==========

to

==========
Revert "Fix deprecatation warning when building for recent SDKs on iOS/OS X."

This reverts CL https://codereview.chromium.org/1563223004/
This reverts commit 7cc0d8562bf8b20b88cc941ba72593cb7230ecf6.

CL 1563223004 introduces two bugs on iOS.
- Encoding the minidump name with extra percent causing crash server to fail
  processing the file.
- Using a released pointer causing random crashes on upload. The
  data, resp, err pointers returned in the NSURLSession completion 
  handler is released at the end of the block. When used later (to get
  the crash ID), it causes a crash.

BUG=569158
==========

[Olivier, 2016-01-21 09:33:09]

On 2016/01/21 09:27:53, blundell wrote:
> LGTM
> 
> Be a little more specific on what the released pointer is that's being used :)

Done.

[Mark Mentovai, 2016-01-21 15:08:50]

LGTM

[Olivier, 2016-01-21 15:54:57]

On 2016/01/21 15:08:50, Mark Mentovai wrote:
> LGTM

Do I need to be commiter to land this ?

[Mark Mentovai, 2016-01-21 16:34:16]

Description was changed from

==========
Revert "Fix deprecatation warning when building for recent SDKs on iOS/OS X."

This reverts CL https://codereview.chromium.org/1563223004/
This reverts commit 7cc0d8562bf8b20b88cc941ba72593cb7230ecf6.

CL 1563223004 introduces two bugs on iOS.
- Encoding the minidump name with extra percent causing crash server to fail
  processing the file.
- Using a released pointer causing random crashes on upload. The
  data, resp, err pointers returned in the NSURLSession completion 
  handler is released at the end of the block. When used later (to get
  the crash ID), it causes a crash.

BUG=569158
==========

to

==========
Revert "Fix deprecatation warning when building for recent SDKs on iOS/OS X."

This reverts CL https://codereview.chromium.org/1563223004/
This reverts commit 7cc0d8562bf8b20b88cc941ba72593cb7230ecf6.

CL 1563223004 introduces two bugs on iOS.
- Encoding the minidump name with extra percent causing crash server to fail
  processing the file.
- Using a released pointer causing random crashes on upload. The
  data, resp, err pointers returned in the NSURLSession completion
  handler is released at the end of the block. When used later (to get
  the crash ID), it causes a crash.

BUG=569158
R=blundell@chromium.org, mark@chromium.org

Committed:
https://chromium.googlesource.com/breakpad/breakpad/+/7da8acc8d4f2f950ae8d80d...
==========

[Mark Mentovai, 2016-01-21 16:34:17]

Committed patchset #1 (id:1) manually as
7da8acc8d4f2f950ae8d80d40614bb5bd3c6cf1d (presubmit successful).