Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(65)

Issue 16195008: Support the new supported_signature_algorithms field of the (Closed)

Created:
6 years, 3 months ago by wtc
Modified:
6 years, 3 months ago
Reviewers:
agl, Ryan Sleevi
CC:
chromium-reviews, cbentzel+watch_chromium.org, agl
Visibility:
Public.

Description

Support the new supported_signature_algorithms field of the CertificateRequest message in TLS 1.2. R=rsleevi@chromium.org BUG=90392 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203445

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+306 lines, -26 lines) Patch
M net/third_party/nss/README.chromium View 1 chunk +1 line, -0 lines 0 comments Download
M net/third_party/nss/patches/applypatches.sh View 1 chunk +2 lines, -0 lines 0 comments Download
A net/third_party/nss/patches/tls12certrequest.patch View 1 chunk +235 lines, -0 lines 0 comments Download
M net/third_party/nss/ssl/ssl3con.c View 11 chunks +62 lines, -3 lines 3 comments Download
M net/third_party/nss/ssl/ssl3ext.c View 4 chunks +4 lines, -23 lines 0 comments Download
M net/third_party/nss/ssl/sslimpl.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
wtc
Please review. This bug causes NSS to incorrectly think a TLS 1.2 CertificateRequest message is ...
6 years, 3 months ago (2013-05-31 01:55:37 UTC) #1
agl
LGTM! Sorry about missing this 1.2 change! https://codereview.chromium.org/16195008/diff/1/net/third_party/nss/ssl/ssl3con.c File net/third_party/nss/ssl/ssl3con.c (right): https://codereview.chromium.org/16195008/diff/1/net/third_party/nss/ssl/ssl3con.c#newcode3956 net/third_party/nss/ssl/ssl3con.c:3956: sizeof supported_signature_algorithms, ...
6 years, 3 months ago (2013-05-31 12:38:24 UTC) #2
wtc
On 2013/05/31 12:38:24, agl wrote: > LGTM! Sorry about missing this 1.2 change! No problem ...
6 years, 3 months ago (2013-05-31 16:30:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wtc@chromium.org/16195008/1
6 years, 3 months ago (2013-05-31 16:31:06 UTC) #4
commit-bot: I haz the power
6 years, 3 months ago (2013-05-31 18:48:55 UTC) #5
Message was sent while issue was closed.
Change committed as 203445

Powered by Google App Engine
This is Rietveld 408576698