Support the new supported_signature_algorithms field of the

Support the new supported_signature_algorithms field of the
CertificateRequest message in TLS 1.2.

R=rsleevi@chromium.org
BUG=90392
TEST=none

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203445

[wtc, 2013-05-31 01:55:37]

Please review.

This bug causes NSS to incorrectly think a TLS 1.2
CertificateRequest message is malformed. Unfortunately the
NSS error code SSL_ERROR_RX_MALFORMED_CERT_REQUEST
is mapped to net::ERR_SSL_PROTOCOL_ERROR, which triggers an
SSL/TLS version fallback and hides this bug. This is another
reason I should refine the SSL error code mapping and only
allow certain errors to trigger SSL/TLS version fallback.

[agl, 2013-05-31 12:38:24]

LGTM! Sorry about missing this 1.2 change!

https://codereview.chromium.org/16195008/diff/1/net/third_party/nss/ssl/ssl3c...
File net/third_party/nss/ssl/ssl3con.c (right):

https://codereview.chromium.org/16195008/diff/1/net/third_party/nss/ssl/ssl3c...
net/third_party/nss/ssl/ssl3con.c:3956: sizeof supported_signature_algorithms,
(nit: Other uses of sizeof seem to have parentheses in this file, but up to
you.)

https://codereview.chromium.org/16195008/diff/1/net/third_party/nss/ssl/ssl3c...
net/third_party/nss/ssl/ssl3con.c:3964: return sizeof
supported_signature_algorithms;
ditto.

[wtc, 2013-05-31 16:30:55]

On 2013/05/31 12:38:24, agl wrote:
> LGTM! Sorry about missing this 1.2 change!

No problem at all. I also just noticed that your patch is
missing the new HMAC-SHA256 cipher suites in RFC 5246, so
I will work on that next to satisfy the "SHA-1 free" item
on some people's checklists.

https://codereview.chromium.org/16195008/diff/1/net/third_party/nss/ssl/ssl3c...
File net/third_party/nss/ssl/ssl3con.c (right):

https://codereview.chromium.org/16195008/diff/1/net/third_party/nss/ssl/ssl3c...
net/third_party/nss/ssl/ssl3con.c:3956: sizeof supported_signature_algorithms,

On 2013/05/31 12:38:24, agl wrote:
> (nit: Other uses of sizeof seem to have parentheses in this file, but up to
> you.)

This file uses both styles with sizeof. The code in these two functions
was adapted from the certificate_types related code on lines 8577-8578,
which is why it's missing the parentheses (the style preferred by
Nelson Bolyard, the original author of this file).

Most people I work with prefer to use parentheses, so I will try to
use that style in new code.

[commit-bot: I haz the power, 2013-05-31 16:31:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wtc@chromium.org/16195008/1

[commit-bot: I haz the power, 2013-05-31 18:48:55]

Change committed as 203445